Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update profile tags display #4002

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

benfurber
Copy link
Member

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix (fixes an issue)
  • Feature (adds functionality)
  • Code style update
  • Refactoring (no functional changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Screenshot 2024-11-12 at 15 02 14

@benfurber benfurber changed the title Feat/map/update tags display feat: update profile tags display Nov 12, 2024
@benfurber
Copy link
Member Author

@davehakkens This is what I'm able to do quickly with the multi-select field to add some more interest.

Screenshot 2024-11-12 at 15 35 59

I could implement the full design but it would require 1-3 days of dev as I'd need to use a completely different component for the field and I'm not sure it's worth doing that at this stage. Thoughts?

@davehakkens
Copy link
Contributor

@davehakkens This is what I'm able to do quickly with the multi-select field to add some more interest.

Cool. But I thought we skipped using the colors for this? (because they can overlap between different spaces and don't align with the academy colors)

Or what logic do you apply to choose a color?

@benfurber
Copy link
Member Author

@davehakkens Oh OK, I thought we decided to prioritise adding extra styling to this and so I went off what was on the final design tag. I'm processing now your comments.

The draft colors I selected link the 'old' PP profile type custom fields.

@benfurber benfurber force-pushed the feat/map/update-tags-display branch from 1ea5ad4 to 5824b76 Compare November 12, 2024 16:53
Copy link

cypress bot commented Nov 12, 2024

onearmy-community-platform    Run #6564

Run Properties:  status check passed Passed #6564  •  git commit 35fb8bfaec: feat: drop colors from profile tags
Project onearmy-community-platform
Branch Review pull/4002
Run status status check passed Passed #6564
Run duration 05m 18s
Commit git commit 35fb8bfaec: feat: drop colors from profile tags
Committer Ben Furber
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 74
View all changes introduced in this branch ↗︎

@davehakkens
Copy link
Contributor

@davehakkens Oh OK, I thought we decided to prioritise adding extra styling to this and so I went off what was on the final design tag. I'm processing now your comments.

Agree we should do some final styling comments, (round borders etc)
But I dont think the mixed color scheme design was fully ready to implement.

However also dont mind if the feature is there. Just dont think PP or PK are ready to properly use it at this point.
But perhaps in the near future

@davehakkens davehakkens added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Nov 13, 2024
@davehakkens
Copy link
Contributor

And what will happen with these old labels and styles, will this data be moved into the new 'system'?
image

@benfurber
Copy link
Member Author

@davehakkens The visible 'old' design (i.e. without the more rounded corners) is because of old data that hasn't been updated in the test DB. I'll update it, that should help you preview #4005 too.

@benfurber benfurber force-pushed the feat/map/update-tags-display branch from 14614a6 to 35fb8bf Compare November 19, 2024 14:23
@benfurber benfurber marked this pull request as ready for review November 19, 2024 14:23
@benfurber benfurber requested a review from a team as a code owner November 19, 2024 14:23
@benfurber benfurber merged commit 19db983 into ONEARMY:master Nov 20, 2024
18 of 19 checks passed
@benfurber benfurber deleted the feat/map/update-tags-display branch November 20, 2024 10:48
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 2.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Mod: Maps 🗺 released Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants