Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop old map #4005

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

benfurber
Copy link
Member

@benfurber benfurber commented Nov 14, 2024

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Feature (adds functionality)

What is the current behavior?

The new map was a very slow render and had a few little bugs.

What is the new behavior?

Fixes the speed issues (and bugs) to a point where the old map can be removed.

@benfurber benfurber added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Nov 14, 2024
Copy link

cypress bot commented Nov 18, 2024

onearmy-community-platform    Run #6644

Run Properties:  status check passed Passed #6644  •  git commit 6c72267ad3: feat: update map filtering display for usability
Project onearmy-community-platform
Branch Review pull/4005
Run status status check passed Passed #6644
Run duration 05m 12s
Commit git commit 6c72267ad3: feat: update map filtering display for usability
Committer Ben Furber
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 71
View all changes introduced in this branch ↗︎

@benfurber benfurber marked this pull request as ready for review November 18, 2024 17:02
@benfurber benfurber requested a review from a team as a code owner November 18, 2024 17:02
@benfurber benfurber mentioned this pull request Nov 18, 2024
10 tasks
@benfurber benfurber force-pushed the feat/map/drop-old-map branch from a3099d4 to cfda27a Compare November 20, 2024 13:40
@benfurber benfurber force-pushed the feat/map/drop-old-map branch from cfda27a to d011652 Compare November 20, 2024 13:44
@benfurber benfurber force-pushed the feat/map/drop-old-map branch from d011652 to 4761818 Compare November 21, 2024 15:31
@benfurber benfurber force-pushed the feat/map/drop-old-map branch from e2da640 to 0049db1 Compare November 21, 2024 15:48
@benfurber benfurber force-pushed the feat/map/drop-old-map branch from 0049db1 to 059e513 Compare November 26, 2024 10:16
@benfurber benfurber force-pushed the feat/map/drop-old-map branch from d6423ae to 2f5cf3c Compare November 26, 2024 17:05
@benfurber benfurber force-pushed the feat/map/drop-old-map branch from 2f5cf3c to 4ac84ca Compare November 27, 2024 15:25
@benfurber benfurber force-pushed the feat/map/drop-old-map branch from 4ac84ca to cfe1f81 Compare November 28, 2024 13:36
packages/components/src/CardList/CardList.tsx Show resolved Hide resolved
src/pages/Maps/Content/MapView/MapList.tsx Outdated Show resolved Hide resolved
src/pages/Maps/Content/MapView/MapList.tsx Outdated Show resolved Hide resolved
src/pages/Maps/Maps.client.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: Maps 🗺 Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
Status: No status
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants