Document and Test PropertyTree Class #5921
Conversation
|
jenkins build this please |
| #include <ostream> | ||
| #include <string> | ||
|
|
||
| #include <stddef.h> |
There was a problem hiding this comment.
we should probably change this to cstddef and instance for std::size_t. but okay to do later.
There was a problem hiding this comment.
we should probably change this to cstddef and instance for std::size_t. but okay to do later.
I'll make a follow-up PR for that.
| @@ -20,51 +20,136 @@ | |||
| #ifndef OPM_PROPERTYTREE_HEADER_INCLUDED | |||
| #define OPM_PROPERTYTREE_HEADER_INCLUDED | |||
|
|
|||
| #include <functional> | |||
There was a problem hiding this comment.
probably missing something but i don't see where this is required?
There was a problem hiding this comment.
probably missing something but i don't see where this is required?
We use std::less<> in the ptree definition.
|
oh, and there are more TAD to be had (all of them can be deduced). |
Right. I'll update the PR accordingly. |
bska
force-pushed
the
document-and-test-property-tree
branch
from
f73a027 to
4130127
Compare
I've pushed an update to that effect now and I'll run a build test. |
|
jenkins build this please |
In particular, add Doxygen-style documentation to the header file and add a simple unit test for the PropertyTree class interface. While here, also add missing headers and prefer template argument deduction over explicit template arguments.
bska
force-pushed
the
document-and-test-property-tree
branch
from
4130127 to
efede0a
Compare
|
jenkins build this please |
And latest update also fixes the "shadowing object" warning that the earlier version introduced... As the PR's approved and the build check is green I'll merge into master. |
In particular, add Doxygen-style documentation to the header file and add a simple unit test for the
PropertyTreeclass interface.While here, also add missing headers and remove those explicit template arguments that are not needed.