Add Property Tree Array Retrieval Mechanism #5922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm creating this PR in draft mode because it depends on, and contains, the earlier PR #5921. I will keep the PR in a draft state until such time as it is ready for review. |
bska
force-pushed
the
property-tree-get-children-as-vector
branch
2 times, most recently
from
bd2d5ed to
02a0715
Compare
|
jenkins build this please |
akva2
approved these changes
Jan 29, 2025
This commit adds a new member function
template <typename T>
std::optional<std::vector<T>>
get_child_items_as_vector(const std::string& child) const;
which retrieves an array-type property value from a property tree.
Initially defined for 'int' and 'double', but could be extended to
'std::string', 'float', or other element types as needed.
bska
force-pushed
the
property-tree-get-children-as-vector
branch
from
02a0715 to
03ac2cb
Compare
|
jenkins build this please |
1 similar comment
|
jenkins build this please |
|
There was build (regression test) failure earlier, but I just reran the build check and it came back green. I'm going to merge this, albeit a bit hesitantly, into the master branch. The earlier build failure suggests that something may be wrong in our system and I'll keep an eye out for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new member function
which retrieves an array-type property value from a property tree. Initially defined for
intanddouble, but could be extended tostd::string,float, or other element types as needed.This is in preparation of making a revised version of #5801.