Fix lookup install and downgrade to LLVM 16 #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkoukpaizan
changed the title
pelesh
approved these changes
Jan 22, 2025
Collaborator
pelesh
left a comment
pelesh
left a comment
There was a problem hiding this comment.
Looks good. I got only one minor suggestion.
Co-authored-by: pelesh <peless@ornl.gov>
pelesh
added a commit
that referenced
this pull request
Apr 14, 2025
* List pwd in CI. * Remove lookup_table.dat install. * Downgrade LLVM from 18 to 16 in CI and update README accordingly. * Update README.md --------- Co-authored-by: pelesh <peless@ornl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44 moved
Examples/ParameterEstimation/lookup_table.dattoExamples/ParameterEstimation/lookup_table.hpp, but was still trying to installlookup_table.datin theCMakeLists.txt.. Surprised CI didn't catch it.This also downgrades LLVM from 18 to 16 in CI. While Gridkit tests currently work with later versions of LLVM, many tests fail within Enzyme itself. (Enzyme CI currently tests LLVM 15 and 16.)