Skip to content

Fix lookup install and downgrade to LLVM 16 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelesh merged 5 commits into from
Jan 22, 2025
Merged

Fix lookup install and downgrade to LLVM 16 #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
416cef5
List pwd in CI.
nkoukpaizan Jan 22, 2025
3687d5c
Remove lookup_table.dat install.
nkoukpaizan Jan 22, 2025
71b8f97
Downgrade LLVM from 18 to 16 in CI and update README accordingly.
nkoukpaizan Jan 22, 2025
c20c5cc
Update README.md
nkoukpaizan Jan 22, 2025
98794e5
Add note about Gridkit being tested with LLVM 16.
nkoukpaizan Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/spack_default_build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,8 @@ jobs:
packages:
llvm:
externals:
- spec: llvm@18
prefix: /usr/lib/llvm-18
- spec: llvm@16
prefix: /usr/lib/llvm-16
EOF

- name: Configure GHCR mirror
Expand All @@ -145,6 +145,9 @@ jobs:
- name: Spack develop gridkit
run: spack -e . develop --path=$(pwd) gridkit@develop

- name: List working directory
run: ls -ltrh $(pwd)/*/*/

- name: Concretize
run: spack -e . concretize

Expand Down
1 change: 0 additions & 1 deletion Examples/ParameterEstimation/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,5 @@ target_link_libraries(paramest
# Fortran linker needed to link to HSL solvers
set_property(TARGET paramest PROPERTY LINKER_LANGUAGE Fortran)
install(TARGETS paramest RUNTIME DESTINATION bin)
install(FILES lookup_table.dat DESTINATION bin)

add_test(NAME ParameterEst COMMAND $<TARGET_FILE:paramest>)
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ You should have all of the following installed before installing GridKit™
- [Suitesparse](https://github.com/DrTimothyAldenDavis/SuiteSparse) >= 5.x (optional)
- [Ipopt](https://github.com/coin-or/Ipopt) >= 3.x (optional)
- [Enzyme](https://github.com/EnzymeAD/Enzyme) >=0.0.131 (optional)
- [LLVM](https://github.com/llvm/llvm-project) >= 18.x
- [LLVM](https://github.com/llvm/llvm-project) >= 15.x. GridKit is
currently tested with LLVM 16.
- [CMake](https://cmake.org/) >= 3.12
- C++ 17 compliant compiler

Expand Down