Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIP backend #30

Merged
merged 13 commits into from
Nov 3, 2023
Merged

HIP backend #30

merged 13 commits into from
Nov 3, 2023

Conversation

pelesh
Copy link
Collaborator

@pelesh pelesh commented Oct 26, 2023 •
edited
Loading

This is pre-hackathon PR with purpose to track multiple issues and code preparation for the event. So far, this includes:

CC @rothpc @cameronrutherford @jaelynlitz @ryandanehy @nkoukpaizan

@pelesh pelesh added the enhancement New feature or request label Oct 26, 2023
@pelesh pelesh added this to the Hackathon milestone Oct 26, 2023
@pelesh pelesh self-assigned this Oct 26, 2023
@pelesh pelesh marked this pull request as draft October 26, 2023 19:00
@pelesh
Copy link
Collaborator Author

pelesh commented Oct 26, 2023

This PR contains a workaround for #28.

pelesh and others added 2 commits October 27, 2023 22:10
@pelesh
First attempt at HIP implemetation
ea279a8
@pelesh @kswirydo
First stab at hip linear algebra. (#39)
3b1b782 
Co-authored-by: kswirydo <kasia.swirydowicz@gmail.com>
@pelesh
Copy link
Collaborator Author

pelesh commented Oct 28, 2023

Merged @kswirydo's implementation of matrix and vector kernels and rebased to develop. All CI pipelines pass, including the incline.

pelesh and others added 4 commits October 30, 2023 20:26
@pelesh
Fix warnings in HIP branch. (#41)
7ea6515 
* Fix warnings in HIP branch.
@pelesh
Use enums instead of strings to denote memory space (#42)
949680f 
* Use enums for memory space ID in matrix classes.

* Use enums for vector class memory space IDs.
@pelesh @cameronrutherford @nkoukpaizan
Review CUDA and HIP configuration in CMake (#48)
9a5fd7a 
* Add first pass CMake cleanup - need to fix include_directories and add custom library macro.

* Fix find HIP cmake function.

* Update CMakePresets.json

Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com>


---------

Co-authored-by: rcrutherford <robert.rutherford@pnnl.gov>
Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com>
@pelesh @kswirydo
Fully functional ROCm-based LU solver (#52)
e01ba3c 
* rocsolver class

* rocsolver-rf functionality test runs

* rocsolver EXAMPLE

* Cleanup before exiting examples and avoid double delete. (#49)

* Enable HIP support in Gramm-Schmidt and FGMRES (#50)

* Enable HIP in GS and FGMRES

* Do not build FGMRES without GPU.

---------

Co-authored-by: kswirydo <kasia.swirydowicz@gmail.com>

---------

Co-authored-by: kswirydo <kasia.swirydowicz@gmail.com>
@pelesh pelesh marked this pull request as ready for review November 2, 2023 01:02
pelesh and others added 2 commits November 1, 2023 21:37
@pelesh
Apparently we need to add rocsolver library to the list of dependencies.
219e645
@pelesh @kswirydo
A working alternative triangular solver (faster) for rocsolverrf (#56)
05a5b2e 
* a WORKING alternative triangular solver (faster) for rocsolverrf

---------

Co-authored-by: kswirydo <kasia.swirydowicz@gmail.com>
@pelesh pelesh requested review from rothpc and cameronrutherford and removed request for maksud November 2, 2023 15:37
pelesh and others added 3 commits November 2, 2023 14:36
@pelesh @kswirydo
working rocsolver FGMRES test (#58)
1a6f9c1 
Co-authored-by: kswirydo <kasia.swirydowicz@gmail.com>
@pelesh
Fix warnings in solver classes. (#62)
1ed777f
@cameronrutherford @pelesh
Incline rocm 5.6.0 dev (#53)
4b3bcf5 
* Add working incline build

* Update spack submodule with rocsolver.

* Update spack and add rocsolver/roctracer to CMake.

* Remove several blanket include_directories.

* Fix exported CMake bug in CXX_STANDARD

* Update examples/resolve_consumer/CMakeLists.txt

---------

Co-authored-by: Ryan Danehy <dane678@deception01.pnl.gov>
Co-authored-by: pelesh <peless@ornl.gov>
@pelesh pelesh requested a review from maksud November 3, 2023 15:29
kswirydo
kswirydo approved these changes Nov 3, 2023
View reviewed changes
resolve/GramSchmidt.cpp Show resolved Hide resolved
resolve/GramSchmidt.cpp Show resolved Hide resolved
resolve/GramSchmidt.cpp Show resolved Hide resolved
resolve/GramSchmidt.cpp Show resolved Hide resolved
resolve/GramSchmidt.cpp Show resolved Hide resolved
resolve/hip/hipKernels.hip Show resolved Hide resolved
resolve/hip/hipKernels.hip Show resolved Hide resolved
resolve/matrix/MatrixHandler.cpp Show resolved Hide resolved
resolve/vector/VectorHandler.hpp Show resolved Hide resolved
tests/unit/vector/VectorHandlerTests.hpp Show resolved Hide resolved
This was referenced Nov 3, 2023
Closed
Closed
This was referenced Nov 3, 2023
Closed
Closed
@pelesh pelesh merged commit 38dcdcd into develop Nov 3, 2023
5 checks passed
This was referenced Nov 7, 2023
Merged
Closed
@pelesh pelesh deleted the hip-first-take-dev branch April 5, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kswirydo kswirydo kswirydo approved these changes

@rothpc rothpc Awaiting requested review from rothpc

@cameronrutherford cameronrutherford Awaiting requested review from cameronrutherford

@maksud maksud Awaiting requested review from maksud

Assignees

@pelesh pelesh

Labels
enhancement New feature or request
Projects
None yet
Milestone
Hackathon
3 participants
@pelesh @kswirydo @cameronrutherford