Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing minor leftovers from Frontier hackathon #69

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Fixing minor leftovers from Frontier hackathon #69

merged 2 commits into from
Nov 8, 2023

Conversation

pelesh
Copy link
Collaborator

@pelesh pelesh commented Nov 7, 2023

Addresses minor issues from PR #30.

Closes #67
Closes #66
Closes #65
Closes #64

@pelesh pelesh added the bug Something isn't working label Nov 7, 2023
@pelesh pelesh requested a review from kswirydo November 7, 2023 22:38
@pelesh pelesh self-assigned this Nov 7, 2023
@pelesh pelesh marked this pull request as draft November 7, 2023 22:38
@pelesh pelesh marked this pull request as ready for review November 7, 2023 22:47
@pelesh
Copy link
Collaborator Author

pelesh commented Nov 7, 2023

@ryandanehy, the Crusher pipeline is failing. It seems there is an authentication failure. Could you please take a look. Btw, is it supposed to be triggered on each push?

Copy link
Collaborator

@kswirydo kswirydo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Compiles and runs correctly.

@pelesh pelesh merged commit 128ad65 into develop Nov 8, 2023
5 of 6 checks passed
@pelesh pelesh deleted the pr30-fix branch December 1, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants