Upgrading the dotenv library to be compatible with the forloeb module #51
Conversation
madsnorgaard
left a comment
madsnorgaard
left a comment
There was a problem hiding this comment.
I notice that this is being merged directly to Master branch. Should it have been develop instead?
|
@madsnorgaard Yes this should go into the develop branch. My mistake and I have changed the base. |
madsnorgaard
left a comment
madsnorgaard
left a comment
There was a problem hiding this comment.
I approve the changes, lets merge them.
load.environment.php
Outdated
| catch (InvalidPathException $e) { | ||
| // Do nothing. Production environments rarely use .env files. | ||
| } | ||
| $dotenv = Dotenv::createImmutable(__DIR__); |
There was a problem hiding this comment.
Can we update this file to the one we have in Drupal composer project?
https://github.com/drupal-composer/drupal-project/blob/9.x/load.environment.php
There was a problem hiding this comment.
Sure thing. As the os2forms_forloeb module has a dependency to the dotenv library as well, this pr OS2Forms/os2forms_forloeb#67 needs to be addressed first and a part of the next release.
There was a problem hiding this comment.
It's now dependant on the following PR OS2Forms/os2forms_forloeb#66
There was a problem hiding this comment.
@lats1
PR
OS2Forms/os2forms_forloeb#66 has been merged :)
|
@lats1 I've resolved conflict that has appeared after applied security updates |
|
@lats1 Does my review comments make sense for you? Otherwise I'd like to hear your point of view why we can't do it :) |
|
Hi @lats1, @madsnorgaard For me, it looks like we stuck with this suggestion. Wouldn't it be a good idea to merge it as it is, and then get it updated to a recent version later? |
|
Did a few releases yesterday and could finally run a |
andriyun
left a comment
andriyun
left a comment
There was a problem hiding this comment.
Looks good.
So we only missing recent changes for load.environment.php file. See comment above
Upgrading the vlucas/dotenv library to match the requirement contraint in the forloeb module for the same library.