Skip to content
This repository was archived by the owner on Apr 2, 2024. It is now read-only.

Conversation

@andriyun
Copy link
Contributor

Hey mates

@madsnorgaard just approved #65

  • there other changes that could be released.

I'd like to make new release for this.

Please review

@andriyun andriyun requested review from lats1 and madsnorgaard August 27, 2021 10:36
@andriyun
Copy link
Contributor Author

I see that all commits was already reviewed before.
See #62, #60, #65

Just to be sure, for the future, is it ok that we merge develop to master if all changes comes from already reviewed PRs
Or you think that it's better to get through review process again?

@madsnorgaard
Copy link
Collaborator

I do not foresee any issues for this particular PR but I would prefer if we do a test of the branch as a minimum in this case. I will note my comments after I get to test the changes locally.

Copy link
Collaborator

@madsnorgaard madsnorgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally - let us merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants