Kubernetes adapter updates #250
Conversation
treydock
commented
Mar 16, 2021
treydock
commented
- Rework how configmap is defined for several purposes
- Support changing mountPath for different files in configmap
- Support mounting subPath files in configmap
- Support mounting files that might not be defined statically but instead generated in init container
- Add some helper environment variable to both main and init container
* Rework how configmap is defined for several purposes * Support mounting at subPath * Support mounting files that might not be defined statically but instead generated in init container * Add some helper environment variable to both main and init container
| @@ -1,12 +1,28 @@ | |||
| module OodCore::Job::Adapters::Kubernetes::Resources | |||
| require_relative 'batch' | |||
There was a problem hiding this comment.
I don't think we need this require here, seems like it'd be cyclical.
| - name: HOME | ||
| value: "<%= home_dir %>" | ||
| - name: GROUP | ||
| value: "<%= group %>" | ||
| - name: GID | ||
| value: "<%= run_as_group %>" | ||
| <%- unless spec.container.env.empty? -%> |
There was a problem hiding this comment.
Seems like we should merge with what the app supplies. Like we supply these items by default, but the app can override them.
I'm thinking about use cases where the k8s cluster doesn't mount a real shared NFS so the user's actual $HOME may not exist in the container and cause problems because HOME is a well known environment variable.
|
Can we break this up into 2 PRs? One for the configmap updates and the other for the environment updates. I think the configmap updates look OK, though I just need to lookup the k8s documentation on those fields for my own edification. But existing test cases didn't need a lot of updates, so that's a good sign. |
|
Will need to merge configmap updates first and then the env updates will have to get updated to ensure the new test file has appropriate env values for testing. I opened #251 for confgmap changes, will open another PR for environment variable changes. |
