Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework how configmap is defined for several purposes #251

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Conversation

treydock
Copy link
Contributor

  • Support mounting at subPath
  • Support mounting files that might not be defined statically but instead generated in init container

configmap related items from #250

* Support mounting at subPath
* Support mounting files that might not be defined statically but instead generated in init container
@treydock
Copy link
Contributor Author

Rebased against master and updated tests

@treydock treydock requested a review from johrstrom March 24, 2021 18:00
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll create the follow up ticket shortly.

@johrstrom johrstrom merged commit c6c833d into master Mar 24, 2021
@johrstrom johrstrom deleted the k8-configmap branch March 24, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants