-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 96 implementation: Deferred C++ plugin loading #8695
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
force-pushed
the
deferred_plugin
branch
from
November 12, 2023 18:44
c0bf2d5
to
522c9d9
Compare
rouault
force-pushed
the
deferred_plugin
branch
5 times, most recently
from
November 13, 2023 19:41
d03dec9
to
97a2c02
Compare
rouault
force-pushed
the
deferred_plugin
branch
2 times, most recently
from
November 14, 2023 19:15
cf3dd37
to
72a60aa
Compare
rouault
force-pushed
the
deferred_plugin
branch
from
November 17, 2023 10:36
72a60aa
to
1c18f62
Compare
elpaso
reviewed
Nov 21, 2023
elpaso
reviewed
Nov 21, 2023
elpaso
reviewed
Nov 21, 2023
elpaso
reviewed
Nov 21, 2023
elpaso
reviewed
Nov 21, 2023
…in if depending on external libraries
…E CMake option to customize error message
…FROM to the list of items that must be set on the proxy
Following comment added in GDALOpenEx():
|
rouault
force-pushed
the
deferred_plugin
branch
from
November 21, 2023 14:37
7a9baa8
to
76fbd1a
Compare
rouault
force-pushed
the
deferred_plugin
branch
from
November 21, 2023 14:45
76fbd1a
to
9d201ef
Compare
jef-n
added a commit
to jef-n/OSGeo4W
that referenced
this pull request
Dec 4, 2023
' update proj-data to 1.16 * update gdal to 3.8.1 * grass*: run clean * fix failed build of gdal-dev (probably after OSGeo/gdal#8695) * grass and qgis rebuilds also fix qgis/QGIS#55476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #8648
On my full configuration with all drivers that can be built as plugins effectively built as plugins (that is those that only depend on libgdal and those that depend on third-party libraries, with -DGDAL_ENABLE_PLUGINS=ON and -DGDAL_ENABLE_PLUGINS_NO_DEPS=ON), the initialization time has dropped from ~300 ms to 70 ms. If building only as plugins drivers that depend on third-party libraries with -DGDAL_ENABLE_PLUGINS=ON (which is the config which makes most sense), it drops to 26 ms, with all 55 plugins in deferred loading mode. One of the biggest culprit identified during the conversion process was the DGNv8 / DWG driver with the gazillions shared libraries of the Teigha SDK.