Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGUI: Fixed PEP8 errors in web_services/ #4706

Merged
merged 5 commits into from
Nov 20, 2024
Merged

wxGUI: Fixed PEP8 errors in web_services/ #4706

merged 5 commits into from
Nov 20, 2024

Conversation

arohanajit
Copy link
Contributor

  • FIxed E402 rebasing module import to the top
  • Fixed F841 removing unused empty list

@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python labels Nov 15, 2024
petrasovaa
petrasovaa reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but the imports likely won't work

@arohanajit
Copy link
Contributor Author

Didn't test, but the imports likely won't work

I have imported modules through a function which allows me to set the path again without raising the flake8 warning

petrasovaa
petrasovaa reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer # noqa instead of the workaround here. Note that Signal can be imported normally, it's not part of r.in.wms.

@petrasovaa petrasovaa added this to the 8.5.0 milestone Nov 19, 2024
@echoix echoix merged commit 546a544 into OSGeo:main Nov 20, 2024
25 of 26 checks passed
@a0x8o a0x8o mentioned this pull request Nov 21, 2024
Merged
@arohanajit arohanajit mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echoix echoix echoix approved these changes

@petrasovaa petrasovaa petrasovaa approved these changes

Assignees
No one assigned
Labels
GUI wxGUI related Python Related code is in Python
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@arohanajit @petrasovaa @echoix