Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD pipeline cleanup #23

Merged
merged 45 commits into from
Nov 26, 2024
Merged

CI/CD pipeline cleanup #23

merged 45 commits into from
Nov 26, 2024

Conversation

a0x8o
Copy link
Owner

@a0x8o a0x8o commented Nov 21, 2024

CI(deps): Update codecov/codecov-action action to v5 (https://github.com/OSGeo/grass/pull/4704[)](https://github.com/a0x8o/grass/commit/2ddf94a18474c8b628b48f975edecc67555e8271)

CI(deps): Update msys2/setup-msys2 action to v2.25.0 (https://github.com/OSGeo/grass/pull/4711[)](https://github.com/a0x8o/grass/commit/6731a3530dacf82c7a092726100e4cbf33280919)

CI(deps): Update ruff to v0.7.4 (https://github.com/OSGeo/grass/pull/4705[)](https://github.com/a0x8o/grass/commit/d5584063f58d637f82b8781b72c4f687287aa557)

(https://github.com/a0x8o/grass/commits?author=echoix) authored 4 days ago
init: Fix F401 Linter Warnings by Replacing Wildcard Imports with Exp…

CI(deps): Update super-linter/super-linter action to v7.2.0 (https://github.com/OSGeo/grass/pull/4713[)](https://github.com/a0x8o/grass/commit/f62faf221d4c5bc3b9d70d918bfb75ab6ce8dde9)

wxGUI: Fix various typos in comments, strings, and methods (https://github.com/OSGeo/grass/pull/4710[)](https://github.com/a0x8o/grass/commit/9313630b839a8692b70e1bb56dafe26fa91b5a6b)

docs: v.out.postgis.html fix manual typos (https://github.com/OSGeo/grass/pull/4717[)](https://github.com/a0x8o/grass/commit/8ce0b06b2fcd221b8e11ad138915d08b5c032941)

packaging: build Windows with libopenblas (https://github.com/OSGeo/grass/pull/4716[)](https://github.com/a0x8o/grass/commit/9984205dc8eaab7f014a5117374565a479297d9d)

docs: update requirements guide (https://github.com/OSGeo/grass/pull/4718[)](https://github.com/a0x8o/grass/commit/24315031ebeb91a7a11a208adb33ac2f864c1065)

CI(deps): Lock file maintenance (https://github.com/OSGeo/grass/pull/4712[)](https://github.com/a0x8o/grass/commit/2af6ffc05767f4e52e7af80db45b5428a7bce4d0)

CI(deps): Update docker/metadata-action action to v5.6.1 (https://github.com/OSGeo/grass/pull/4719[)](https://github.com/a0x8o/grass/commit/1b1febf0ddc65d3a76e5085dc97ec6ed3f165498)

docs: fix broken HTML (https://github.com/OSGeo/grass/pull/4720[)](https://github.com/a0x8o/grass/commit/25cf476108cdad604e1b4c8f826f8fa8fe7ca82c)

docs: v.mkgrid.html fix manual typos (https://github.com/OSGeo/grass/pull/4724[)](https://github.com/a0x8o/grass/commit/bb04c32f00f3a6993dc5ae52183161180a0f71af)

wxGUI: Fixed PEP8 errors in web_services/ (https://github.com/OSGeo/grass/pull/4706[)](https://github.com/a0x8o/grass/commit/546a544caa4e9e18b9d07e653579562331df067f)

wxGUI: Fixed PEP8 errors in wxplot/ (https://github.com/OSGeo/grass/pull/4699[)](https://github.com/a0x8o/grass/commit/2b169286f685f33fe27c23dc85a23934cf5d89fe)

CI(deps): Update codecov/codecov-action action to v5.0.4 (https://github.com/OSGeo/grass/pull/4721[)](https://github.com/a0x8o/grass/commit/720274886aeb0e603784f4e5b6d181d0004079cf)

tests: replaced module imports to the top (https://github.com/OSGeo/grass/pull/4656[)](https://github.com/a0x8o/grass/commit/36359e23449482c03ebfdc2c1055dddcd2fff7ab)

renovate bot and others added 17 commits November 15, 2024 17:51
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* CI(deps): Update ruff to v0.7.4

* style: Solve root-logger-call (LOG015)

Ruff rule: https://docs.astral.sh/ruff/rules/root-logger-call/

This rule is newly detected by ruff

* style: Trim trailing whitespace for pre-commit

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
…licit Imports in __init__.py (#4647)

* fixed F401 in app

* experimental update

* update

* fixed

* removed comment

* removed duplicates

* added Popen

* fix setup

* fixed

* Remove fixed F401 and F403 from .flake8 exclusions

---------

Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
* wxGUI: Fix typo in rlisetup's createCircle method

* wxGUI: Fix typo in rlisetup's SamplingType for circle

* lib: Fix typo for circle in area_poly1.c

* Fix typo in "contiguous"

* wxGUI: Fix various simple typos in comments

* wxGUI: Fix georectifier typo

* wxGUI: Fix various simple typos in comments

* wxGUI: Fix typo for l_order_list

* wxGUI: Fix typo for "execute"

* wxGUI: Fix various simple typos

* wxGUI: Fix typo for "calculate"

* wxGUI: Fix various simple typos

* wxGUI: Fix typo for "Unknown"

* wxGUI: Fix typo for "SetGCPStatus"

* wxGUI: Fix typo for "tuple"

* Fix typo for "delete"

* wxGUI: Fix various simple typos

* wxGUI: Fix typo for "SetPlotsMode"

* wxGUI: Fix typo for "computational"

* wxGUI: Fix various simple typos
This small PR fixes

- HTML id attributes
- a `href` typo
echoix and others added 11 commits November 21, 2024 15:18
* CI(Travis): Set pyenv global to an already installed Python version

Might become unavailable, it will remain dependant on what Travis installs in their images
* r.to.vect: new flag to re-center centroids
At time the GRASS GIS main compilation with addons with `cron_grass_preview_build_binaries.sh` is broken:

https://grass.osgeo.org/grass85/binary/linux/snapshot/build.log.txt

```
...
Parsing <v.what.strds.timestamp>... SUCCESS
Parsing <wx.metadata>... FAILED
Parsing <wx.mwprecip>... FAILED
Parsing <wx.stream>... FAILED
Parsing <wx.wms>... FAILED
+ cp /home/neteler/.grass8/addons/modules.xml /var/www/code_and_data/addons/grass8/modules.xml
+ export ARCH
+ export ARCH_DISTDIR=/home/neteler/src//main/dist.x86_64-pc-linux-gnu
+ export GISBASE=/home/neteler/src//main/dist.x86_64-pc-linux-gnu
+ export VERSION_NUMBER=8.5
+ python3 /home/neteler/src//main/man/build_keywords.py /var/www/code_and_data/grass85/manuals/ /var/www/code_and_data/grass85/manuals/addons/
Traceback (most recent call last):
  File "/home/neteler/src//main/man/build_keywords.py", line 202, in <module>
    build_keywords("md")
  File "/home/neteler/src//main/man/build_keywords.py", line 68, in build_keywords
    from build_md import (
  File "/home/neteler/src/main/man/build_md.py", line 264, in <module>
    man_dir = os.path.join(os.environ["MDDIR"], "source")
  File "/usr/lib/python3.9/os.py", line 679, in __getitem__
    raise KeyError(key) from None
KeyError: 'MDDIR'
```

This PR attemps to fix this bug (inspired by `man/build_html.py`). Tested on grass.osgeo.org (without log file).

Co-authored-by: Martin Landa <landa.martin@gmail.com>
* Fix Resource Leak issue

* G_free()
A local array was used to store column name and column
type for each column, and a pointer to this local array
was stored and accessed outside its scope, which can cause
undefined behavior.

To avoid this, use memory from heap to store this information
so that it's accessible outside where its defined and free
this memory at the end to avoid memory leaks.

This was found using cppcheck tool.

Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com>
….43.0 (#4743)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* CI(deps): Update ruff to v0.8.0

* style: PT004 has been removed in ruff 0.8.0, ignoring had no effect

* style: Fix unraw-re-pattern (RUF039)

Ruff rule: https://docs.astral.sh/ruff/rules/unraw-re-pattern/

Newly introduced ruff rule

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
neteler and others added 4 commits November 23, 2024 15:14
This PR updates the Markdown support in the parser for the manual in terms of

- converting keywords to lowercase (e.g. `dist.x86_64-pc-linux-gnu/docs/mkdocs/site/keywords.html#modis`)
- replacing of `.html` with `.md` in certain cases
Co-authored-by: Markus Neteler <neteler@osgeo.org>
* man/build_html: Use context manager for get_desc

* man/build_topics: Use context managers for opening files

* man/build_rest: Replace read_file and write_file with Path.read_text and Path.write_text

* man/build_rest: Use context manager for get_desc

* man/build_index_rest: Use a context manager for opening file

* man/build_keywords: Use a context manager for opening files

* man/build_class_graphical: Use a context manager for opening files

* man/build_full_index_rest: Use a context manager for opening files

* man/build_full_index: Use a context manager for opening files

* man/build_class_rest: Use a context manager for opening files

* man/build_class: Use a context manager for opening files

* style: Remove unneeded SIM115 exclusions in man/

* man/build_topics: Use context managers for opening keyfile

* man/build_html: Add missing Path import

* man/build_keywords: Ignore line too long (E501)

* Sort imports in build_rest

* man/build_topics: write_footer need to be inside keyfile context manager
While the Graphical User Interface is important, it lacked an own "landing page" which also appears in the markdown sidebar.

This PR adds a wxGUI introduction page.
renovate bot and others added 7 commits November 24, 2024 12:08
* CI(deps): Update echoix/setup-OSGeo4W action to v0.2.0

* CI(OSGeo4W): Use setup-OSGeo4W's root path output

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
…4751)

This PR provides minor HTML fixes to `lib/db/` and `db/` manual related files:

- convert several `README` to `README.md`
- update selected broken URLs
- partially sync `grass-mysql.html` and `grass-mesql.html` incl. section order
- fix typo: statemets -> statements

Extra:
- avoid <br> tags within <em> as not converted properly to Markdown
This PR fixes some broken HTML tags identified with a test run of the HTML validation with super-linter.

See logs showing the errors at:
https://github.com/echoix/grass/actions/runs/12001379426/job/33451802353?pr=303#step:4:8310
Fix spelling errors.

 * allows to <verb> -> allow <verb>ing
 * overlaping       -> overlapping
 * refernce         -> reference

Co-authored-by: Markus Neteler <neteler@osgeo.org>
Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
@a0x8o a0x8o merged commit 058dbde into a0x8o:main Nov 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.