Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use client.Client instead of K8sClient in finalizer. #1183

Merged
merged 2 commits into from
Dec 22, 2024

remove which can ensure by chainsaw test `setup`

a856765
Select commit
Loading
Failed to load commit list.
Merged

feat: use client.Client instead of K8sClient in finalizer. #1183

remove which can ensure by chainsaw test `setup`
a856765
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 22, 2024 in 0s

29.30% (-0.90%) compared to 60ef5a2

View this Pull Request on Codecov

29.30% (-0.90%) compared to 60ef5a2

Details

Codecov Report

Attention: Patch coverage is 6.38298% with 44 lines in your changes missing coverage. Please review.

Project coverage is 29.30%. Comparing base (60ef5a2) to head (a856765).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
pkg/k8sutils/finalizer.go 0.00% 42 Missing ⚠️
main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1183      +/-   ##
==========================================
- Coverage   30.20%   29.30%   -0.90%     
==========================================
  Files          55       56       +1     
  Lines        6294     6469     +175     
==========================================
- Hits         1901     1896       -5     
- Misses       4200     4399     +199     
+ Partials      193      174      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.