New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use client.Client instead of K8sClient in finalizer. #1183

Merged

drivebyer merged 2 commits into OT-CONTAINER-KIT:master from drivebyer:dynamic-client

Dec 22, 2024

Merged

feat: use client.Client instead of K8sClient in finalizer. #1183

remove which can ensure by chainsaw test `setup`

Codecov / codecov/patch failed Dec 22, 2024 in 1s

6.38% of diff hit (target 30.20%)

View this Pull Request on Codecov

6.38% of diff hit (target 30.20%)

Annotations

Check warning on line 123 in main.go

codecov / codecov/patch

main.go#L122-L123

Added lines #L122 - L123 were not covered by tests

Check warning on line 25 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L25

Added line #L25 was not covered by tests

Check warning on line 29 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L29

Added line #L29 was not covered by tests

Check warning on line 34 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L34

Added line #L34 was not covered by tests

Check warning on line 44 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L44

Added line #L44 was not covered by tests

Check warning on line 48 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L48

Added line #L48 was not covered by tests

Check warning on line 53 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L53

Added line #L53 was not covered by tests

Check warning on line 63 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L63

Added line #L63 was not covered by tests

Check warning on line 67 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L67

Added line #L67 was not covered by tests

Check warning on line 72 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L72

Added line #L72 was not covered by tests

Check warning on line 86 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L86

Added line #L86 was not covered by tests

Check warning on line 99 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L99

Added line #L99 was not covered by tests

Check warning on line 105 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L105

Added line #L105 was not covered by tests

Check warning on line 114 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L108-L114

Added lines #L108 - L114 were not covered by tests

Check warning on line 123 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L123

Added line #L123 was not covered by tests

Check warning on line 134 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L128-L134

Added lines #L128 - L134 were not covered by tests

Check warning on line 149 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L143-L149

Added lines #L143 - L149 were not covered by tests

Check warning on line 161 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L161

Added line #L161 was not covered by tests

Check warning on line 171 in pkg/k8sutils/finalizer.go

codecov / codecov/patch

pkg/k8sutils/finalizer.go#L165-L171

Added lines #L165 - L171 were not covered by tests

View more details on Codecov