Do not lcase element or attribute names that match SVG or MathML name… #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s exactly > Currently all names are converted to lowercase which is ok when > you're using it for HTML only, but if there is an SVG image nested > inside the HTML it breaks. For example, when `viewBox` attribute is > converted to `viewbox` the image is not displayed correctly. This commit splits *HtmlLexer*.*canonicalName* into variants which preserve items on whitelists derived from the SVG and MathML specifications, and adjusts callers of *canonicalName* to use the appropriate variant. Fixes #182
|
Simple test for viewBox: PolicyFactory policyFactory = new HtmlPolicyBuilder()
.allowElements("svg")
.allowAttributes("viewBox").onElements("svg")
.toFactory();
String svg = "<svg viewBox=\"0 0 0 0\"></svg>";
assertEquals(svg, policyFactory.sanitize(svg)); |
|
@zeeneir Added tests. Let me know if this PR solves your problem. |
|
Looks good to me. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s exactly
This commit splits HtmlLexer.canonicalName into variants which preserve
items on whitelists derived from the SVG and MathML specifications, and
adjusts callers of canonicalName to use the appropriate variant.
Fixes #182
@wookie41 @zeeneir do you have an example that I can turn into a unit test?