Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not lcase element or attribute names that match SVG or MathML name… #206

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Do not lcase element or attribute names that match SVG or MathML name… #206

merged 2 commits into from
Jul 13, 2020

Commits on Jul 3, 2020

  1. Do not lcase element or attribute names that match SVG or MathML name… 

    …s exactly

> Currently all names are converted to lowercase which is ok when
> you're using it for HTML only, but if there is an SVG image nested
> inside the HTML it breaks.  For example, when `viewBox` attribute is
> converted to `viewbox` the image is not displayed correctly.

This commit splits *HtmlLexer*.*canonicalName* into variants which preserve
items on whitelists derived from the SVG and MathML specifications, and
adjusts callers of *canonicalName* to use the appropriate variant.

Fixes #182
    @mikesamuel
    mikesamuel committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    247cdb6 View commit details
    Browse the repository at this point in the history

  2. add unittests for mixed-case SVG names

    @mikesamuel
    mikesamuel committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    04492f7 View commit details
    Browse the repository at this point in the history