-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:FillValue numbers correct? #102
Comments
Hi Emma. I think that the Extending on your point, I personally use Thanks! |
I just realized that this issue is related to #70. Let's converge the discussions here, and whenever this is closed, let's remember to close that issue as well. I think that the main point over there was to be easy to aggregate chunks (note, it could be as simple as aggregating multiple dives from the same deployment). Otherwise, it would require a prior check on A note to be considered. Some Apps have default To be clear, my suggestion is to recommend using |
If this is stated clear in the format, that is fine with me. |
Following recommendation of #102 to clarify how to manage fix values
@castelao @vturpin Sorry must have missed this notification in my emails. The complication in having multiple values for I do think it's important to prescribe a In terms of what the value is, i don't have a strong opinion, just need to make sure it could never be an actual value. I think we ended up having this problem with engineering cycle number in the EGO file and it meant the EGO checker failed. For LAT LON DEPTH these will be easy to prescribe. For parameters values, we may need to separate out a value for science parameters and engineering parameters. If we go with NaN how is this stored in the NetCDF files? Are we sure this is consistent across all software NetCDF library versions? |
Hi, fil values will need to differ by observed property. The convention in other networks is that they are harmonised across the network. Effectively there would need to be a code table with the recommended fill value of each OG1 term. This approach make is easier for developers of tools and services that use the OG data . There are times when the recommended fill value need to be updated as happened recently when the output form backscatter sensors changed. |
The NaN is a special encoding for floating-point, so it should be stored in a NetCDF as this specific f32/f64. I.e., a valid float with the same number of bits like +Inf or -Inf. This seems to be a standard defined back on 1985, so any library that still can't handle that should probably be considered a bug. I still think that using NaN is convenient for developers and users. If someone has to check in a table that 9999.9999 was used for missing latitude, how different would it be to look the manual that NaN was used here or check a table full of NaNs if one wants to be consistent with other systems. If anyone has a strong opinion about defining tables, we need a volunteer to write those tables and think about where to keep it. Hopefully something easy for machine-to-machine communication. |
If we don't have a volunteer to create such a reference table we will need to allow a free value (once more, as long as the same data type of the variable) to be able to move forward. Note that there is no restriction on CF side, so a free value is a legit option and hence should be a job for any CF-compliant App to deal with normalizing the FillValue before aggregating it. |
Also related to to #70 |
* FillValue for PARAM Following recommendation of #102 to clarify how to manage fix values * Update OG_Format.adoc A decision from meeting 2023-04-24. * Update OG_Format.adoc New suggestion from Jenn --------- Co-authored-by: Guilherme Castelão <guilherme@castelao.net>
Hello,
I was wondering if the fill values are correct?
LATITUDE_GPS:FillValue = -9999.9;
LATITUDE:FillValue = -9999.9;
TIME:FillValue = -1.0 ;
CF conventions seem to refer to -999.9f
Thanks,
Emma
The text was updated successfully, but these errors were encountered: