Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FillValue for PARAM #114

Merged
merged 3 commits into from
Apr 24, 2023
Merged

FillValue for PARAM #114

merged 3 commits into from
Apr 24, 2023

Conversation

vturpin
Copy link
Member

@vturpin vturpin commented Sep 21, 2022

Following recommendation of #102 to clarify how to manage fix values

Proponents:
Moderator: @OceanGlidersCommunity/format-mantainers

Type of PR

  • Typo without possible change of interpretation of the related text.
  • Fix of some error, inconsistency, unforeseen limitation.
  • Style that only affects visually the compiled document
  • Addition that does not require change in the current structure.
  • Enhancement that require changes to improve the format.

Related Issues

Dates when it got review approvals

The suggestion made by @castelao has been made a month ago.
So I push a PR to close the issue

Release checklist

  • Approved by at least two members of the committee?
  • There were modifications after the review approvals? If so, please
    ask reviewers to update their review.
  • Proponents and moderador should explicitly agree that it is ready to
    to merge.
  • The moderador is the one in charge to actually merge or close this PR
    according to the final decision.

For maintainers

  • Update the moderator with a volunteer from the committee. It would be
    best to have one single moderator to guide and help this PR to move
    forward. It is OK to update the moderador pass it to another one.
  • Confirm that the associated branch was deleted after the merging.
  • Wrap-up and close the related issues.

Comments

Following recommendation of #102 to clarify how to manage fix values
OG_Format.adoc Outdated Show resolved Hide resolved
Copy link
Collaborator

@justinbuck justinbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed at OG 1.0 meeting 24th April 2023, is inconstant with geophysical variables section.
Updated recommendation based on feedback needed.

A decision from meeting 2023-04-24.
New suggestion from Jenn
Copy link
Collaborator

@justinbuck justinbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by consensus at OG 1.0 meeting 24th April 2023

@castelao castelao merged commit dce146c into main Apr 24, 2023
@castelao castelao deleted the vturpin-patch-5 branch April 24, 2023 14:25
@callumrollo callumrollo mentioned this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants