-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🍰 feat: Landing Page etc. #4555
Conversation
…cial into 4549-landing-page-def-route+have-internal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean to me.I wondered whyyou included a <br>
in each page default. Shouldn't that be done with css? I also wondered if the LANDING_PAGE
variable is at the right place in config/links.js
. That's all I found. I can approve if you'd like. Obviously I have not tested this
It’s a good hint to have the margin in the CSS instead of the The I would love if @Mogge can review and test this a bit … 😍 |
🍰 Pullrequest
Landing Page etc.
Issues
Todo