Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍰 feat: Landing Page etc. #4555

Merged
merged 10 commits into from
Jul 26, 2021
Merged

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Jul 20, 2021

🍰 Pullrequest

Landing Page etc.

Issues

Todo

  • Lets have it configurable if a user lands on login, registration, an external landing page or an internal one, if they address the pure domain like https://staging.ocelot.social .
  • Have the possibility of an internal landing page like the imprint.
  • have internal support page as well

@Tirokk Tirokk marked this pull request as draft July 20, 2021 09:40
@Tirokk Tirokk self-assigned this Jul 20, 2021
@Tirokk Tirokk requested review from Mogge and ulfgebhardt July 20, 2021 14:41
@Tirokk Tirokk marked this pull request as ready for review July 20, 2021 14:42
Copy link
Member

@ulfgebhardt ulfgebhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean to me.I wondered whyyou included a <br> in each page default. Shouldn't that be done with css? I also wondered if the LANDING_PAGE variable is at the right place in config/links.js. That's all I found. I can approve if you'd like. Obviously I have not tested this

@Tirokk
Copy link
Member Author

Tirokk commented Jul 20, 2021

It’s a good hint to have the margin in the CSS instead of the <br> at each beginning of the HTML. @ulfgebhardt
If it’s okay then I like to merge this PR and have it in my mind for the next time I touch it, because I needed half a day of restarting the test to get it through.

The LANDING_PAGE is right in this file, because it can be a full redirected external URL as well in case a network will have this.

I would love if @Mogge can review and test this a bit … 😍

@Tirokk Tirokk changed the title 🍰 feat: [WIP] Landing Page etc. 🍰 feat: Landing Page etc. Jul 21, 2021
@Tirokk Tirokk requested a review from Elweyn July 21, 2021 09:34
webapp/middleware/authenticated.js Show resolved Hide resolved
webapp/pages/organization.spec.js Show resolved Hide resolved
webapp/pages/support.spec.js Show resolved Hide resolved
@Tirokk Tirokk merged commit 0154d3d into master Jul 26, 2021
@Tirokk Tirokk deleted the 4549-landing-page-def-route+have-internal branch July 26, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 [Feature] Landing Page
3 participants