-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🍰 Post In Groups #5380
feat: 🍰 Post In Groups #5380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Mogge ,
now we get to the center of our efforts!
I did the first part of my review. I have reviewed until first half of postsInGroups.spec.js
.
I'll do the next part later.
So I don't await that this is done if I go ahead.
I have some suggestions and wrote down some of my understandings …
May you like to seed some posts in the groups?
That would be really cool for our stagings and for the development of the webapp part.
Do you like to merge this first or do we do a compare of the webapp part to your code before we merge it to the groups branch?
PS:
Comments of my understanding and the transparence of it for you to check if I'm right:
(more of them you'll find in the code…)
- if I'm joining a group via
JoinGroup
noCANNOT_SEE
relation changes, because at the moment:- in
public
groups I can see all post already before joining and getting ausual
member- therefore I can still see all posts
- in
closed
groups I can not see the posts before joining and getting apending
member- therefore I can still see no posts
hidden
groups I cannot join this way
- in
Co-authored-by: Wolfgang Huß <wolle.huss@pjannto.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good stuff dear.
I found some additional things in the masses of tests … 😅
But not a lot … 😁
…st leaving public group and visibility of posts in public group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly works well, but:
- we may have one misunderstanding
- and your reverted a change you already did
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Mogge ,
super cool !!! 😍💥
I approve! 🚀🚀🚀💫💫💫
🍰 Pull Request
Post in groups.
groupId
parameter to create post mutation:IN
to post in group:CANNOT_SEE
to all posts a user cannot see due to group restrictions.relates #5385