Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [WIP] 🍰 Validate Group Name Etc. In Backend #5426

Closed

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Sep 29, 2022

🍰 Pull Request

I do this again in new PR #5662 , because of to much changes in the master

Validate group name etc in backend.

Issues

Todo

  • rename:
    • descriptiongroupDescription
    • descriptionExcerptgroupDescriptionExcerpt
    • DESCRIPTION_EXCERPT_HTML_LENGTHGROUPDESCRIPTION_EXCERPT_HTML_LENGTH
  • has the goal a maximum?
    • no I think
  • move the backend/scr/db/graphql folder out of the db folder one folder level higher that it fits together with docs: 🍰 Document GraqhQL Playground #5253
  • have all fields be HTML saniticed which will be displayed in the DOM?

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
HighCrit HighCrit

Verified

This commit was signed with the committer’s verified signature. The key has expired.
HighCrit HighCrit

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…'groupDescriptionExcerpt' to be able to sanitize HTML
…OUT_HTML_LENGTH_MIN' and 'DESCRIPTION_EXCERPT_HTML_LENGTH' → 'GROUPDESCRIPTION_EXCERPT_HTML_LENGTH' to be able to sanitize HTML
Base automatically changed from 5397-Refine-Group-Creation-And-Group-Edit to 5059-epic-groups October 10, 2022 06:16
Base automatically changed from 5059-epic-groups to master October 25, 2022 12:17
…cial into 5059-groups/5425-validate-group-name-etc-in-backend

# Conflicts:
#	backend/src/middleware/excerptMiddleware.js
#	backend/src/middleware/slugifyMiddleware.spec.js
#	webapp/components/Group/GroupForm.vue
#	webapp/layouts/default.vue
@Tirokk
Copy link
Member Author

Tirokk commented Nov 9, 2022

Will be replaced by #5662

@Tirokk Tirokk closed this Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 [Feature] Validate Group Name Etc. In Backend
1 participant