Replace the Pixel trait with ArrayCast and cast functions and increase the MSRV to 1.51.0
#254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ogeon
changed the title
Pixel trait with ArrayCast and cast functionsPixel trait with ArrayCast and cast functions and increase the MSRV to 1.51.0
Benchmark for 4717c56Click to view benchmark
|
Benchmark for 18b8f21Click to view benchmark
|
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Aug 22, 2021
255: Add unsigned integer casting to `cast` and make `Packed` general purpose r=Ogeon a=Ogeon I have added a `UintCast` trait and casting functions, similar to what I did for arrays in #254, to make it less awkward when casting collections of unsigned integers. I have also made `Packed` a part of `cast` and made it work with any color space and any storage format (including arrays and other unsigned integers). It implements `ArrayCast` if it wraps an array and `UintCast` if it wraps an unsigned integer. There's also a bunch of related QoL changes for `Rgb` and `Luma` (which has gotten `Packed` compatibility), as well as some code that has been moved around. ## Breaking Change The `Packed` struct takes its storage format as a type parameter, is no longer specific to RGB, and has moved into `cast`. `RgbChannels` has been renamed to `ComponentOrder` and has been moved into `cast`. Co-authored-by: Erik Hedvall <erikwhedvall@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
Pixeltrait with a new system for casting that is based on fixed size arrays as a primitive representation. The initial implementation covers most of the use cases forPixeland some additional features (castingBox<[T]>andVec<T>for example). The missing feature is the implicit truncationPixeldid. The new system leaves it to the user to truncate collections where necessary.I couldn't come up with a good trait system that would be universal enough, so I decided to start with this setup with free functions. It will at least give us the base to build something more convenient on.
See #227 for some background and an earlier solution idea.
Breaking Change
This removes the
PixelandRawPixeltraits and replaces it with a system that is based on theArrayCastmarker trait and a number of primitive cast functions.From,Into,AsRef,AsMut,TryFromandTryInto.Veccan currently only be cast via the functions in thecastmodule. Something more ergonomic may come in a later change.The MSRV is bumped to 1.51.0 to get access to const generics.