Add unsigned integer casting to cast and make Packed general purpose
#255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for dbeb343Click to view benchmark
|
Benchmark for 6cc2632Click to view benchmark
|
Benchmark for e62bc8fClick to view benchmark
|
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a
UintCasttrait and casting functions, similar to what I did for arrays in #254, to make it less awkward when casting collections of unsigned integers. I have also madePackeda part ofcastand made it work with any color space and any storage format (including arrays and other unsigned integers). It implementsArrayCastif it wraps an array andUintCastif it wraps an unsigned integer.There's also a bunch of related QoL changes for
RgbandLuma(which has gottenPackedcompatibility), as well as some code that has been moved around.Breaking Change
The
Packedstruct takes its storage format as a type parameter, is no longer specific to RGB, and has moved intocast.RgbChannelshas been renamed toComponentOrderand has been moved intocast.