Safari Search not working

[curlz620]

If this is a bug report please make sure you have filled the following in:
(If it's not a bug and a feature request then just remove the below)

Plex Requests.Net Version: 1.9.0

Operating System:Windows Server 2008

Mono Version:

Applicable Logs (from /logs/ directory or the Admin page):

Logs go here (Please make sure you remove any personal information from the logs)

Reproduction Steps: iOS Safari search does not work. Entering in the movie title does not allow anything to come up. Hitting the Magnifying glass or pressing enter does not work. However, this function works fine on Android Chrome, or Firefox on mobile.

Please include any steps to reproduce the issue, this the request that is causing the problem etc.

[tidusjar]

This might be the same issue as #492

[curlz620]

I do not think it is a touchscreen issue since I cannot reproduce it on my Android Phone, Windows Surface Tablet. After work I will take a look on my Wife's iMac and see if its safari on there as well.

Also, I did not have this issue prior to the most recent update.

[fash202]

noticed this issue on my friends iPhone. Also had the problem on a Samsung Galaxy S7 using Dolphin Browser. Works fine on that phone using Chrome browser though.

[perspellemann]

I have the same issue. iPhone 6s+ and iPad Air 2 with Chrome works, Safari doesn't. Tried on a Macbook Air (2015) with Safari too, didn't work.

[Collisionc]

This is the same issue as: #403

Some browsers have issues with setTimeout.

[tidusjar]

Build if anyone wants to confirm it's fixed: https://ci.appveyor.com/project/tidusjar/requestplex/build/1.9.759/artifacts

[ShepherdDimaloun]

i tested your build, but a friend of mine have still problems with searching, like above

[ewascome]

Tested and confirm that still have searching issues with Safari. I think it is because of the use of arrow functions in your javascript.

Change Line 569 of search.js from
if (!seenSeasons.find(x => x === episodes.season)) {
to
if (!seenSeasons.find(function(x){return x===episodes.season;})) {

Also line 581 of requests.js from
var foundItem = tvObject.find(x => x.seasonNumber === episode.seasonNumber);
to
var foundItem = tvObject.find(function (x) { return x.seasonNumber === episode.seasonNumber; });

[tidusjar]

What difference will that make? It looks to do the same thing?

[ewascome]

Safari Browser does not support Arrow Functions.

https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Functions/Arrow_functions#Browser_compatibility

[tidusjar]

OH!

[tidusjar]

New build with those changes https://ci.appveyor.com/project/tidusjar/requestplex/build/artifacts

[ShepherdDimaloun]

I can confirm it is working now, as @ewascome says, arrow functions doesnt work in all browsers, Internet Explorer doesnt support arrow functions too.

i noticed a small styling, maybe it is the way it should be but i think there needs to be a small gab between available and the other button.

edit: is it also possible to start the plex app from the browser? noticed when you press view in plex button you opened new tab heading to plex.tv and not on mobile plex app.

[tidusjar]

@ShepherdDimaloun It might be possible but I am not sure, since I wouldn't really know if you are on a mobile device and also If you have the app installed 😞

[ShepherdDimaloun]

@tidusjar with javascript, it is possible to check what device you are using, even jQuery is capable of that.
I have developed a android app and it is possible to open an app with a html anchor element, dont know if plex app accept extra parameters. I dont know how it works for IOS.

[tidusjar]

Yeah I understand that I could detect it. But what would happen if the user doesn't have the app installed?

[ShepherdDimaloun]

here is the info about app links for Android: https://developer.android.com/training/app-links/index.html