Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]Multiple OneSignal instance #741

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Jul 1, 2024

Description

One Line Summary

Fixes additional instance of OneSignalAndroid or OneSignaliOS from being created when calling OneSignal methods in Awake().

Details

Motivation

Removes logged error "Additional instance of OneSignalAndroid/OneSignaliOS created."
Reproducible when calling OneSignal.Debug.LogLevel = LogLevel.Verbose; in Awake().

Scope

OneSignal.Default now manages the platform instance entirely instead of setting it again in platform initialization. Since OneSignal.Default already creates the platform instance in _getDefaultInstance(), we can remove the setter and the internal classes that used it: OneSignalAndroidInit, OneSignaliOSInit, OneSignalNativeInit.

Testing

Manual testing

Tested calling OneSignal debug and initialization methods in Awake(), app build with Unity 2022.3.10f1 of the OneSignal example app on a emulated Pixel 4 with Android 12 and a physical iPhone 12 with iOS 17.5.1.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

OneSignal.Default calls _getDefaultInstance() which creates the platform instance. There doesn't seem to be a need to have an Init for each platform that sets OneSignal.Default
Remove unused DidInitialize property since OneSignaliOSInit and OneSignalAndroidInit have been removed
Prevent creating new instance as it could lead to something being set on one instance and then it being lost as it is replaced with a different one.
@shepherd-l shepherd-l requested a review from jkasten2 July 1, 2024 15:38
@shepherd-l shepherd-l merged commit 65abdaa into main Jul 3, 2024
1 check passed
@shepherd-l shepherd-l deleted the fix/multipleOneSignalInstance branch July 3, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants