Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fixes additional instance of
OneSignalAndroid
orOneSignaliOS
from being created when calling OneSignal methods inAwake()
.Details
Motivation
Removes logged error
"Additional instance of OneSignalAndroid/OneSignaliOS created."
Reproducible when calling
OneSignal.Debug.LogLevel = LogLevel.Verbose;
inAwake()
.Scope
OneSignal.Default
now manages the platform instance entirely instead of setting it again in platform initialization. SinceOneSignal.Default
already creates the platform instance in_getDefaultInstance()
, we can remove the setter and the internal classes that used it:OneSignalAndroidInit
,OneSignaliOSInit
,OneSignalNativeInit
.Testing
Manual testing
Tested calling OneSignal debug and initialization methods in
Awake()
, app build with Unity 2022.3.10f1 of the OneSignal example app on a emulated Pixel 4 with Android 12 and a physical iPhone 12 with iOS 17.5.1.Affected code checklist
Checklist
Overview
Testing
Final pass
This change is