Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]Multiple OneSignal instance #741

Merged
merged 4 commits into from
Jul 3, 2024
Merged

[Fix]Multiple OneSignal instance #741

merged 4 commits into from
Jul 3, 2024

Commits on Jun 28, 2024

  1. Remove setter for OneSignal.Default 

    OneSignal.Default calls _getDefaultInstance() which creates the platform instance. There doesn't seem to be a need to have an Init for each platform that sets OneSignal.Default
    @shepherd-l
    shepherd-l committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    a55aac2 View commit details
    Browse the repository at this point in the history

  2. Remove DidInitialize property 

    Remove unused DidInitialize property since OneSignaliOSInit and OneSignalAndroidInit have been removed
    @shepherd-l
    shepherd-l committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    1aa3102 View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG

    @shepherd-l
    shepherd-l committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d17416b View commit details
    Browse the repository at this point in the history

  4. Return after additional instance error 

    Prevent creating new instance as it could lead to something being set on one instance and then it being lost as it is replaced with a different one.
    @shepherd-l
    shepherd-l committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    aa776fd View commit details
    Browse the repository at this point in the history