Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the OneSignal iOS SDK version in v3 #765

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Nov 7, 2024

Description

One Line Summary

Bump included OneSignal iOS SDK version in the player model version of the OneSignal Unity SDK

Details

Motivation

Apply the following iOS fix to the Unity SDK for:
Tapping on launch URLs fails with iOS 18

Scope

Updates included iOS SDK from 3.12.9 to 3.12.10

  • Replace deprecated openURL method preventing launch URLs
  • Update privacy manifest User Defaults API reason to include app groups
  • For full changes, see the native release notes

Testing

Manual testing

Tested OneSignal initialization, app build with Unity 2021.3.36f1 and Xcode 16.1 of the OneSignal example app on a physical iPhone 12 with iOS 17.5.1.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@shepherd-l shepherd-l changed the title Update OneSignal iOS SDK in v3 Update the OneSignal iOS SDK version in v3 Nov 7, 2024
@shepherd-l shepherd-l merged commit df624c8 into player-model-main Nov 7, 2024
1 check passed
@shepherd-l shepherd-l deleted the updateOneSignaliOSSDK branch November 7, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants