Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x.x] Replace deprecated openURL method preventing launch URLs #1493

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Oct 7, 2024

Description

One Line Summary

The method openURL: (doc) appears to be completely deprecated on ios 18, so replace with the updated openURL:options:completionHandler: (doc).

Details

Motivation

Tapping on launch URLs fails with iOS 18 when using the deprecated method.
The user model SDK already uses the newer API.

Scope

Update a deprecated method with its replacement in 2 places (both are tested).

Testing

Unit testing

None

Manual testing

iPhone 16 simulator on iOS 18.0

  • Reproduced the issue that the method is no-op
  • Works after updating the method
  • Tested both changes

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

nan-li and others added 2 commits October 6, 2024 17:24
* openURL: is completely deprecated on ios 18, so replace with the updated openURL:options:completionHandler:
* `macos-latest` recently migrated from macos-12 to macos-14 Arm64, the latter of which does not ship with swiftlint
* `macos-latest-large` is also a macos-14 image and does ship with swiftlint
@nan-li nan-li requested a review from emawby October 7, 2024 15:28
@nan-li
Copy link
Contributor Author

nan-li commented Oct 7, 2024

The CI environment may have changed. Ran this CI 3 times, all had some tests failing after 10-11 minutes. Passes locally.
The last 2 PRs ran around 3-4 minutes, all passing.

@nan-li nan-li changed the title [player model] Replace deprecated openURL method [3.x.x] Replace deprecated openURL method Oct 7, 2024
@nan-li nan-li merged commit 4cc5ae7 into player-model-main Oct 7, 2024
1 of 2 checks passed
@nan-li nan-li deleted the fix/deprecated_openurl branch October 7, 2024 18:15
@nan-li nan-li mentioned this pull request Oct 7, 2024
@nan-li nan-li changed the title [3.x.x] Replace deprecated openURL method [3.x.x] Replace deprecated openURL method preventing launch URLs Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants