[3.x.x] Add release workflow github action #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
requested changes
Oct 30, 2024
| @@ -24,6 +24,8 @@ create_xcframework() { | |||
| echo "Created ${FRAMEWORK_FOLDER_NAME}" | |||
| echo "Archiving ${FRAMEWORK_NAME}" | |||
|
|
|||
| xcodebuild -list | |||
There was a problem hiding this comment.
Is this just to help debug if something goes wrong?
There was a problem hiding this comment.
It's copied over from the file on main: https://github.com/OneSignal/OneSignal-iOS-SDK/pull/1340/files
However it may be leftover from the testing process.
.github/workflows/cd.yml
Outdated
| with: | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| repository: 'OneSignal/OneSignal-iOS-SDK' | ||
| force: true |
There was a problem hiding this comment.
Does this need to be force? Or is it required to create the branch?
There was a problem hiding this comment.
It's copied over from the file on main: https://github.com/OneSignal/OneSignal-iOS-SDK/pull/1340/files
However I have tested it and it is not necessary.
* Force push is not necessary * xcodebuild list seems leftover from testing
nan-li
force-pushed
the
player_model_add_cd
branch
from
9528dfd
to
eea3dcb
Compare
jkasten2
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Action for building the release binaries and updating the Package.swift for a release
Details
Adapted from the workflow on
main.This action is intended to
It does NOT
How to use this action:
Motivation
Improve the release process
Manual testing
Released 3.12.10 with this action.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is