-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x.x] Add release workflow github action #1496
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,94 @@ | ||
name: iOS CD | ||
|
||
on: | ||
workflow_dispatch: | ||
inputs: | ||
version: | ||
type: string | ||
description: "The version number of the release" | ||
required: true | ||
release_branch: | ||
type: string | ||
description: "The release branch with bumped version numbers for the release" | ||
required: true | ||
|
||
jobs: | ||
build: | ||
name: Build the binaries for the release and create a PR | ||
runs-on: macos-13 | ||
|
||
steps: | ||
- name: setup xcode | ||
uses: maxim-lobanov/setup-xcode@v1 | ||
with: | ||
xcode-version: '15.2' | ||
- name: Checkout OneSignal-iOS-SDK | ||
uses: actions/checkout@v4 | ||
with: | ||
ref: ${{github.event.inputs.release_branch}} | ||
|
||
- name: Install the Apple distribution certificate and provisioning profile | ||
uses: apple-actions/import-codesign-certs@v2 | ||
with: | ||
keychain-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }} | ||
p12-file-base64: ${{ secrets.CERTIFICATES_P12 }} | ||
p12-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }} | ||
|
||
- name: Install the Apple distribution certificate and provisioning profile | ||
uses: apple-actions/import-codesign-certs@v2 | ||
with: | ||
create-keychain: false # do not create a new keychain for this value | ||
keychain-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }} | ||
p12-file-base64: ${{ secrets.DEV_CERTIFICATES_P12 }} | ||
p12-password: ${{ secrets.DEV_CERTIFICATES_P12_PASSWORD }} | ||
# - name: Bump Version Number | ||
# run: | | ||
- name: Build Binaries | ||
run: | | ||
cd iOS_SDK/OneSignalSDK | ||
chmod +x ./build_all_frameworks.sh | ||
./build_all_frameworks.sh | ||
shell: bash | ||
- name: Code Sign | ||
run: | | ||
cd iOS_SDK/OneSignalSDK | ||
codesign --timestamp -v --sign "Apple Distribution: OneSignal, Inc. (J3J28YJX9L)" OneSignal_Core/OneSignalCore.xcframework | ||
codesign --timestamp -v --sign "Apple Distribution: OneSignal, Inc. (J3J28YJX9L)" OneSignal_Extension/OneSignalExtension.xcframework | ||
codesign --timestamp -v --sign "Apple Distribution: OneSignal, Inc. (J3J28YJX9L)" OneSignal_Outcomes/OneSignalOutcomes.xcframework | ||
codesign --timestamp -v --sign "Apple Distribution: OneSignal, Inc. (J3J28YJX9L)" OneSignal_XCFramework/OneSignal.xcframework | ||
shell: bash | ||
- name: Update Swift Package | ||
run: | | ||
cd iOS_SDK/OneSignalSDK | ||
chmod +x ./update_swift_package.sh | ||
./update_swift_package.sh ${{github.event.inputs.version}} | ||
shell: bash | ||
- name: Commit Changes | ||
run: | | ||
git config --local user.email "noreply@onesignal.com" | ||
git config --local user.name "SyncR 🤖" | ||
git add . | ||
git commit -m "Release ${{github.event.inputs.version}}" | ||
|
||
- name: Pushing changes | ||
uses: ad-m/github-push-action@master | ||
with: | ||
github_token: ${{ secrets.GITHUB_TOKEN }} | ||
repository: 'OneSignal/OneSignal-iOS-SDK' | ||
force: true | ||
branch: ${{github.event.inputs.release_branch}} | ||
|
||
- name: "Submitting PR" | ||
uses: octokit/request-action@v2.x | ||
with: | ||
route: POST /repos/{owner}/{repo}/pulls | ||
owner: OneSignal | ||
repo: OneSignal-iOS-SDK | ||
head: ${{github.event.inputs.release_branch}} | ||
base: player-model-main | ||
title: | | ||
"Release ${{github.event.inputs.version}}" | ||
body: | | ||
"Add Release Notes For Review Here" | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,8 @@ create_xcframework() { | |
echo "Created ${FRAMEWORK_FOLDER_NAME}" | ||
echo "Archiving ${FRAMEWORK_NAME}" | ||
|
||
xcodebuild -list | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this just to help debug if something goes wrong? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's copied over from the file on main: https://github.com/OneSignal/OneSignal-iOS-SDK/pull/1340/files |
||
|
||
xcodebuild archive ONLY_ACTIVE_ARCH=NO -scheme ${BUILD_SCHEME} -destination="generic/platform=iOS Simulator" -archivePath "${SIMULATOR_ARCHIVE_PATH}" -sdk iphonesimulator SKIP_INSTALL=NO BUILD_LIBRARIES_FOR_DISTRIBUTION=YES | ||
|
||
xcodebuild archive -scheme ${BUILD_SCHEME} -destination="generic/platform=iOS" -archivePath "${IOS_DEVICE_ARCHIVE_PATH}" -sdk iphoneos SKIP_INSTALL=NO BUILD_LIBRARIES_FOR_DISTRIBUTION=YES | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be force? Or is it required to create the branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's copied over from the file on main: https://github.com/OneSignal/OneSignal-iOS-SDK/pull/1340/files
However I have tested it and it is not necessary.