Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always create new player ids on app install #914

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Always create new player ids on app install #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f071c0
no longer using identifierForVendor
emawby Apr 9, 2021
f1c05ef
removing adid from userstate
emawby Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion iOS_SDK/OneSignalSDK/Source/OSUserState.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ THE SOFTWARE.
@property (strong, nonatomic, readwrite, nullable) NSString *deviceOs;
@property (strong, nonatomic, readwrite, nullable) NSNumber *timezone;
@property (strong, nonatomic, readwrite, nullable) NSString *timezoneId;
@property (strong, nonatomic, readwrite, nullable) NSString *adId;
@property (strong, nonatomic, readwrite, nullable) NSString *sdk;
@property (strong, nonatomic, readwrite, nullable) NSString *sdkType;
@property (strong, nonatomic, readwrite, nullable) NSString *externalUserId;
Expand Down
1 change: 0 additions & 1 deletion iOS_SDK/OneSignalSDK/Source/OSUserState.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ - (NSDictionary*)toDictionary {
_deviceOs, @"device_os",
_timezone, @"timezone",
_timezoneId, @"timezone_id",
_adId, @"ad_id",
_sdk, @"sdk",
nil];

Expand Down
1 change: 0 additions & 1 deletion iOS_SDK/OneSignalSDK/Source/OneSignal.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1743,7 +1743,6 @@ + (OSUserState *)createUserState {
userState.deviceOs = [[UIDevice currentDevice] systemVersion];
userState.timezone = [NSNumber numberWithInt:(int)[[NSTimeZone localTimeZone] secondsFromGMT]];
userState.timezoneId = [[NSTimeZone localTimeZone] name];
userState.adId = [[[UIDevice currentDevice] identifierForVendor] UUIDString];
userState.sdk = ONESIGNAL_VERSION;

// should be set to true even before the API request is finished
Expand Down