Vue 3 fixes #2887
Merged
Vue 3 fixes #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
emccorson
commented
Apr 1, 2021
•
emccorson
commented
- Disable index buttons at first/last items in Carousel example
- Rename model prop and event to work with Vue 3 v-model
- Bump vue to vue@^3.0.6 because of bug fix: kebab-case events are attached correctly on web components, see #2841 vuejs/core#2847
- Add deviceBackButton event to emits key
Since Vue 3, v-model now expects the value prop to be `modelValue` and the update event to be `update:modelValue`. https://v3.vuejs.org/guide/migration/v-model.html
This was needed to get a bug fix released in vue@3.0.6: vuejs/core#2847
This ensures we are using a version of vue that has the bug fix we need. vuejs/core#2847
emccorson
added a commit
that referenced
this pull request
Apr 20, 2021
These were commited directly to master but should be commited to a feature branch and then merged. This commit should be reverted in the feature-vue3 branch. This commit reverts: 166fa51 Merge branch 'more-vue3-fixes' (PR #2887) 906432e chore(vue): Pin vue dependency to vue@^3.0.6 a7a96d7 fix(vue): Add deviceBackButton event to emits key 94fcde8 chore(vue): Recreate lockfile to get latest packages respecting semver 14b42c2 fix(vue): Rename model prop and event to work with Vue 3 v-model e05f1b4 fix(vue): Disable index buttons at first/last items in Carousel example 4c1be56 fix(vue): Set prop default to function in VOnsTabbar a01cee9 Merge branch 'vue3-tabbar-fixes' (PR #2884) e26aa98 fix(vue): Clearer buttons in Tabbar example 5dd6863 fix(vue): Stop marking whole tab object as raw in Tabbar example 53b4bf5 fix(vue): Model index in Tabbar example fba4f72 fix(vue): Fix icons in Tabbar example for Ionicons v4 ab6125a fix(vue): Set tabbarStyle prop default to an empty object ae64de9 fix(vue): Disable index buttons on first and last tabs in tabbar example ec6dfe1 fix(vue): Unset ons-tab active when VOnsTab active prop is false 0c4d325 fix(vue): Formatting fix for Tabbar example due to incredible ugliness 8b2f0e6 fix(vue): Remove unused line of code 042fbea Merge branch 'unrecognized-listener-fixes' (PR #2881) 84ecb24 fix(vue): Stop tabbar listeners firing twice for ons-page events 07496c1 fix(vue): Stop navigator listeners firing twice for ons-page events dc70ad8 fix(vue): Stop filtering by ons native events in unknownListeners 25d5169 fix(vue): Remove root node unrecognizedListeners 3f035f8 Merge branch 'vue3-examples-warnings' (PR #2879) eb4a570 fix(vue): Silence warnings in Segment example with markRaw 9040f33 fix(vue): Silence warnings in Tabbar example with markRaw a77930f fix(vue): Silence warnings in vue-onsenui-examples App.vue 440cdb8 Merge branch 'vue3-navigator-fixes' (PR #2878) be6b60d fix(vue): Fix onsNavigatorOptions as top-level property not working 22849db fix(vue): Use markRaw in navigator example to silence warnings fc82188 fix(vue): Use refs when getting data from the navigator page stack a8ddcb3 fix(vue): Stop trying to access props argument in props default function 491f279 fix(vue): Use refs instead of this.$children 8039d17 Revert "fix(vue): Replace this.$children" f092ccb Merge branch 'replace-children' (PR #2876) b5d0e07 fix(vue): Replace this.$children f04c452 fix(vue): Deprecate setting VOnsNavigator initial page by slot da12495 Merge branch 'issue-2870' (PR #2875) 4852e8a fix(vue): Fix custom listeners being passed to pages and tabs 2a0d3bd Merge branch 'fix-vue-components' (PR #2869) a6e76e9 fix(vue): Add emits key for automatically generated components 2cdea2a fix(vue): Remove unrecognizedListeners from gulp generate-components 3f54122 fix(vue): Fix gulpfile package.json path 716459a fix(vue): Add emits key for manually written components 3273de0 fix(vue): Remove most instances of unrecognizedListeners 5a495b2 fix(vue): Split vue examples entry file into single file components adaef64 chore(vue): Package lock changed ab8b73d fix(vue): Externalize vue properly in UMD rollup config 0d0503f fix(vue): Add ons- element to custom elements whitelist in rollup config 91e133a fix(vue): Remove 'generated' comment from VOnsListItem f9d3794 Merge branch 'esm-fixes' (PR #2862) 879704a fix(vue): Use app instance instead of global Vue for ESM build 87efbdc fix(vue): Use .vue extension for imports in index.esm.js b56d765 chore(vue): Add separate ESM build command and rollup config file 9f44925 chore(vue): Stop examples app linting vue-onsenui depdendency ef3a929 Merge branch 'vue3-fixes' (PR #2859) be8666a fix(vue): Rename destroyed to unmounted f54a7ea fix(vue): Rename beforeDestroy to beforeUnmount 5e76999 fix(vue): Replace $options._componentTag with $options.name 7816cf5 fix(vue): Remove unneeded src/index.html in examples app addba47 Merge branch 'umd-build-vue' (PR #2858) 2cfadb9 chore(vue): Add vue-loader-v16 dependency to examples 6b5cbad fix(vue): Use app instance instead of global Vue in UMD build for Vue 3 67c2197 chore(vue): Fix rollup excludes files 587951d fix(vue): Fix linting errors after Vue 3 upgrade 103dc89 chore(vue): Bump dependencies to Vue 3 e270d0d Merge branch 'issue-2855' (PR #2856) 87c8c12 chore(vue): Move UMD minify to npm script 474a1aa chore(vue): Add UMD build script and separate UMD rollup config 8696756 chore(vue): Fix rollup external test regex 213446b Merge branch 'issue-2853' (PR #2854) 98b890f chore(vue): Bump rollup-plugin-eslint 77cb1f5 chore(vue): Fix rollup config path to core package.json 49a0863 chore(vue): Add lint npm script b694729 chore(vue): Make bindings source and examples app share eslint config 5d58314 chore(vue): Bump linting dependencies to match examples app c569621 Merge branch 'vue3-examples' (PR #2852) 813ff65 fix(vue): Fix linting errors in examples app after Vue 3 upgrade a0ca80d fix(vue): Fix bad v-for key in examples app c83efd5 fix(vue): Remove deprecated `is` on HTML element in examples app 7c9b407 chore(vue): Remove deprecated v-on.native modifier in examples app 56ea8b0 chore(vue): Add emits keys for events in examples app 97ead47 fix(vue): Replace deprecated slots syntax in examples app 85a4119 fix(vue): Replace deprecated sync usage in examples app 6dbd988 chore(vue): Use Vue 3 for examples app c10f4b1 Merge pull request #2846 from OnsenUI/issue-2829 c1f209b fix(vue): Fix linting error 0c6495a chore(vue): Open browser when running examples dev server 0bc3201 chore(vue): Fix CSS not being loaded in examples project 59b2ef8 chore(vue): Use runtime compiler in examples project 9947fb1 chore(vue): Bump Vue version to match Vue examples project f7078e9 chore(vue): Move to monorepo structure using npm workspaces 02c6413 Merge branch 'issue-2826' (PR #2831) 8429fc1 chore(vue): Fix vue-template-compiler version mismatch e334c86 chore(vue): Replace yarn with npm 3fdc3f2 chore(vue): Bump rollup version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.