fix: kebab-case events are attached correctly on web components, see #2841 #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowings-zy
force-pushed
the
fix#2841
branch
from
e1dc7f3
to
5dcf45c
Compare
@posva hi, I have added test case for this commit |
edison1105
approved these changes
Feb 4, 2021
HcySunYang
approved these changes
Feb 4, 2021
posva
approved these changes
Feb 7, 2021
This was referenced Mar 8, 2021
emccorson
added a commit
to OnsenUI/OnsenUI
that referenced
this pull request
Apr 1, 2021
This was needed to get a bug fix released in vue@3.0.6: vuejs/core#2847
emccorson
added a commit
to OnsenUI/OnsenUI
that referenced
this pull request
Apr 1, 2021
This ensures we are using a version of vue that has the bug fix we need. vuejs/core#2847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #2841 .
The kebab-case custom event
foo-barin web components will parse tofoobar. Vue will addfoobaras the name of event listener. I think this needs a fix.Close #2841 .
: )