-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCSP responder for v3 documents #243
Comments
Hi @morgatron, thanks for the suggestion! We'll add this into our backlog and keep you updated here when it gets implemented. |
Thanks @HJunyuan ! |
To be clear, it's looking like this will be important for our customer. We'll be needing the feature in the next couple of months... any clarity you can provide would be fantastic. |
I could be wrong, but it looks as simple as replacing case v3.RevocationType.OcspResponder:
throw new Error("Ocsp revocation type not yet supported for v3"); with case v3.RevocationType.OcspResponder:
if (typeof location === "string") {
return isRevokedByOcspResponder2({
merkleRoot,
targetHash,
proofs,
location,
})
} in I can raise a PR if desired, but I'm not sure I understand how tests work for this currently so I'm not sure I can update them. Let me know! |
Yes you are right! We'll just need to focus on creating the tests and it should be done. Will get started on this around this or next week or when the new sprint starts. |
- Implement handling of `OCSP_RESPONDER` type of revocation for OA v3 documents - Add tests for DID-issued OA v3 documents with OCSP_RESPONDER type of revocation - Housekeeping of filenames for fixtures BREAKING CHANGE: the old OCSP Responder implementation (where it checks by by document id instead of merkle root & intermediate hashes) is now deprecated It is no longer possible to perform OCSP revocation by document id as mentioned in #228 Fixes #243
🎉 This issue has been resolved in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Great!! |
The OCSP responder looks great for DID-signed documents, especially those for v3. However it seems that v3 documents aren't currently supported:
(from
didSignedDocumentStatus.ts
)This seems pretty straightforward to add however, using the v2 code as a guide.
Are there any plans to add this?
The text was updated successfully, but these errors were encountered: