Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement OCSP Responder for OA v3 documents #245

Merged
merged 9 commits into from
Feb 6, 2023
Merged

feat: implement OCSP Responder for OA v3 documents #245

merged 9 commits into from
Feb 6, 2023

Conversation

HJunyuan
Copy link
Member

@HJunyuan HJunyuan commented Feb 3, 2023 •
edited
Loading

BREAKING CHANGE

TL;DR
It is no longer possible to perform OCSP revocation by document id in subsequent versions of this library

This PR removes the old OCSP Responder implementation fallback where it checks by by document id instead of merkle root & intermediate hashes (#228)

New features

  • Implement handling of OCSP_RESPONDER type of revocation for OA v3 documents
  • Add tests for DID-issued OA v3 documents with OCSP_RESPONDER type of revocation
  • Housekeeping of filenames for fixtures
  • Fixes OCSP responder for v3 documents #243

@HJunyuan HJunyuan marked this pull request as ready for review February 6, 2023 03:47
cavacado
cavacado approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@cavacado cavacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w8 on at least 1 more dev's approval for merge

@HJunyuan HJunyuan changed the title feat: implement OCSP Responder for OA v3 documents BREAKING CHANGE: implement OCSP Responder for OA v3 documents Feb 6, 2023
simboonlong
simboonlong approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@simboonlong simboonlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HJunyuan HJunyuan changed the title BREAKING CHANGE: implement OCSP Responder for OA v3 documents feat: implement OCSP Responder for OA v3 documents Feb 6, 2023
@HJunyuan HJunyuan merged commit edeccf6 into master Feb 6, 2023
@HJunyuan HJunyuan deleted the feat/ocsp-responder-for-v3 branch February 6, 2023 08:38
@john-dot-oa
Copy link
Contributor

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simboonlong simboonlong simboonlong approved these changes

@cavacado cavacado cavacado approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OCSP responder for v3 documents
4 participants
@HJunyuan @john-dot-oa @simboonlong @cavacado