-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector data cubes #441
Vector data cubes #441
Conversation
GeoPandas also uses "geometry" by default for the column that contains the vector data, so "geometry" will sound conceptually familiar to people that know GeoPandas |
This is ready for final review. |
…parameters, returns, dimensions) and their relation to subtypes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve (with minor remark)
This is also ready for final review. There are some issues with the relevant tooling (redoc), so I can't express everything 1:1 in the API spec. The name for the vector dimension is now "geometries" (plural) in accordance with "bands", okay? @soxofaan @mkadunc @aljacob @clausmichele @jdries @dthiex @LukeWeidenwalker @pierocampa |
I don't think that changing to plural "geometries" is really necessary. Apart from "bands", all dimension types and names are/look singular: "spatial", "temporal", "x", "y", "other". As another data point here: geopandas uses singular "geometry" as column type and name in data frames, e.g. see https://geopandas.org/en/stable/docs/reference/api/geopandas.GeoDataFrame.html#geopandas.GeoDataFrame |
Are you saying
should change to
? |
I guess so. If I understand correctly, the dimension type has already been settled on plural "geometries" in merged PR stac-extensions/datacube#10
Sidenote: I noticed that @aljacob made related comment at Open-EO/openeo-processes#382 (review) |
In principle we can still change everything as we just merged the PRs yet, but we have not released anything yet (including the STAC extension). Anyway, I'm merging this now and will then create a separate issue for this. Makes it easier to work on further improvements. |
Minor additions to the API only, Mostly reflecting the changes in stac-extensions/datacube#10 and the addition to the JSON Schema for the new
datacube
subtype.