Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VectorCubes: fix/improve Point handling in aggregate_spatial #239

Closed
soxofaan opened this issue Oct 13, 2022 · 1 comment
Closed

VectorCubes: fix/improve Point handling in aggregate_spatial #239

soxofaan opened this issue Oct 13, 2022 · 1 comment
Assignees
@soxofaan

Comments

@soxofaan
Copy link
Member

Spin off from Open-EO/openeo-python-driver#141 :
using DriverVectorCube by default in aggregate_spatial surfaced some issues related to Point geometry handling.
As a quick fix, Point geometry handling was reverted to non-DriverVectorCube behavior (see Open-EO/openeo-python-driver@2ec255e and Open-EO/openeo-python-driver@4927eee).
But this special case code path has to be eliminated again, and Point geometries should be supported properly in the vector cube way
soxofaan added a commit that referenced this issue Oct 13, 2022
@soxofaan
#239 Add tests about Point support in aggregate_spatial
38f7caa
soxofaan added a commit that referenced this issue Oct 13, 2022
@soxofaan
Issue #239 Add tests about Point support in aggregate_spatial
58084b4
soxofaan added a commit that referenced this issue Oct 14, 2022
@soxofaan
fixup! Issue #239 Add tests about Point support in aggregate_spatial
ec7ec9f
soxofaan added a commit that referenced this issue Oct 14, 2022
@soxofaan
Issue #239 Add tests about Point support in aggregate_spatial
ab4ad05
soxofaan added a commit that referenced this issue Oct 14, 2022
@soxofaan
Issue #239 Fix latitude implementation of TestCollectionLonLat
91e3725 
rows apparently run from north to south
soxofaan added a commit that referenced this issue Oct 14, 2022
@soxofaan
Issue #239 Fix latitude implementation of TestCollectionLonLat
0f565f7 
rows apparently run from north to south
soxofaan added a commit that referenced this issue Oct 14, 2022
@soxofaan
Issue #239 Add tests about Point support in aggregate_spatial
6082eb9
soxofaan added a commit that referenced this issue Oct 18, 2022
@soxofaan
Issue #239 consolidate Point handling in GeometryCollection
3afd276
soxofaan added a commit that referenced this issue Oct 18, 2022
@soxofaan
Issue #239 eliminate Point handling logic
5e82cc0 
load_collection projected_polygons: the special case for Point handling can be removed without other changes apparently
soxofaan added a commit that referenced this issue Oct 18, 2022
@soxofaan
fixup! Issue #239 eliminate Point handling logic
5890e47
soxofaan added a commit that referenced this issue Oct 18, 2022
@soxofaan
Issue #239 Add tests about Point support in aggregate_spatial
8dfe9f0
soxofaan added a commit that referenced this issue Oct 18, 2022
@soxofaan
Issue #239 consolidate Point handling in GeometryCollection
b94e137
soxofaan added a commit that referenced this issue Oct 18, 2022
@soxofaan
Issue #239 eliminate special case handling for Points
c2437a1 
Point specifics are now covered in to_projected_polygons
soxofaan added a commit that referenced this issue Oct 18, 2022
@soxofaan
fixup! Issue #239 eliminate special case handling for Points
6b11db3
soxofaan added a commit that referenced this issue Oct 18, 2022
@soxofaan
Issue #239 Add tests about Point support in aggregate_spatial
c0c5e6b
soxofaan added a commit that referenced this issue Oct 18, 2022
@soxofaan
Issue #239 consolidate Point handling in GeometryCollection
04ffc0a
soxofaan added a commit that referenced this issue Oct 18, 2022
@soxofaan
Issue #239 eliminate special case handling for Points
994f891 
Point specifics are now covered in to_projected_polygons
@soxofaan soxofaan self-assigned this Oct 19, 2022
soxofaan added a commit that referenced this issue Oct 19, 2022
@soxofaan
Update to new openeo_driver.util.geometry
1417405 
- `to_projected_polygons` now also handles point buffering
- related to #239
soxofaan added a commit to Open-EO/openeo-geopyspark-integrationtests that referenced this issue Oct 19, 2022
@soxofaan
trim down aggregate_spatial point handling tests
2d5c967 
cases are now covered directly in openeo-geopyspark-driver
just kept 2 cases (simplest and most complex) in integration tests

related to Open-EO/openeo-geopyspark-driver#239
soxofaan added a commit that referenced this issue Oct 19, 2022
@soxofaan
Issue #239 More aggregate_spatial with point geometry tests
c56d1d8
@soxofaan
Copy link
Member Author

Fixed/address various issues in various projects now

time to close this one

@soxofaan soxofaan mentioned this issue Oct 19, 2022
Closed
soxofaan added a commit to Open-EO/openeo-python-driver that referenced this issue Oct 20, 2022
@soxofaan
Also buffer points on DriverVectorCube in dry run _normalize_geometry
063920a 
related to Open-EO/openeo-geopyspark-driver#239
soxofaan added a commit that referenced this issue Oct 20, 2022
@soxofaan
Issue #239 quickfix for to_projected_polygons with path as geometry
b816f20
soxofaan added a commit to Open-EO/openeo-python-driver that referenced this issue Oct 20, 2022
@soxofaan
Also buffer points on DriverVectorCube in dry run _normalize_geometry
2b4ccd4 
tests for 063920a

related to Open-EO/openeo-geopyspark-driver#239
@soxofaan soxofaan mentioned this issue Oct 20, 2022
Closed
soxofaan added a commit that referenced this issue Oct 20, 2022
@soxofaan
fixup! Issue #239 quickfix for to_projected_polygons with path as geo…
2826f02 
…metry
@soxofaan soxofaan mentioned this issue Oct 24, 2022
Open
soxofaan added a commit to Open-EO/openeo-python-driver that referenced this issue Oct 24, 2022
@soxofaan
Remove unused/deprecated buffer_point_approx
fea6a35 
replaced by `GeometryBufferer` helper 
related to #141, Open-EO/openeo-geopyspark-driver#239, #148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soxofaan soxofaan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soxofaan