Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert inline geojson to vectorcube in aggregate_spatial #141

Closed
jdries opened this issue Sep 27, 2022 · 5 comments
Closed

convert inline geojson to vectorcube in aggregate_spatial #141

jdries opened this issue Sep 27, 2022 · 5 comments
Assignees
@soxofaan

Comments

@jdries
Copy link
Contributor

jdries commented Sep 27, 2022

No description provided.

@soxofaan soxofaan transferred this issue from Open-EO/openeo-geopyspark-driver Oct 5, 2022
soxofaan added a commit that referenced this issue Oct 5, 2022
@soxofaan
Issue #114/#141 convert inline GeoJSON in aggregate_spatial to Vector…
0d68104 
…Cube
soxofaan added a commit that referenced this issue Oct 5, 2022
@soxofaan
fixup! Issue #114/#141 convert inline GeoJSON in aggregate_spatial to…
886b663 
… VectorCube
soxofaan added a commit that referenced this issue Oct 6, 2022
@soxofaan
fixup! Issue #114/#141 convert inline GeoJSON in aggregate_spatial to…
4a6d5ea 
… VectorCube
soxofaan added a commit that referenced this issue Oct 6, 2022
@soxofaan
fixup! fixup! Issue #114/#141 convert inline GeoJSON in aggregate_spa…
2864f25 
…tial to VectorCube
soxofaan added a commit that referenced this issue Oct 6, 2022
@soxofaan
fixup! fixup! fixup! Issue #114/#141 convert inline GeoJSON in aggreg…
f85e929 
…ate_spatial to VectorCube
soxofaan added a commit that referenced this issue Oct 6, 2022
@soxofaan
fixup! fixup! fixup! fixup! Issue #114/#141 convert inline GeoJSON in…
bce577b 
… aggregate_spatial to VectorCube
@soxofaan soxofaan mentioned this issue Oct 7, 2022
Closed
soxofaan added a commit that referenced this issue Oct 7, 2022
@soxofaan
fixup! fixup! fixup! fixup! fixup! Issue #114/#141 convert inline Geo…
73ae035 
…JSON in aggregate_spatial to VectorCube
soxofaan added a commit that referenced this issue Oct 7, 2022
@soxofaan
Issue #114/#141 convert inline GeoJSON in aggregate_spatial to Vector…
c8fcd91 
…Cube
soxofaan added a commit that referenced this issue Oct 7, 2022
@soxofaan
fixup! Issue #114/#141 convert inline GeoJSON in aggregate_spatial to…
a27cc9b 
… VectorCube
soxofaan added a commit that referenced this issue Oct 7, 2022
@soxofaan
fixup! Issue #114/#141 convert inline GeoJSON in aggregate_spatial to…
4e02771 
… VectorCube
soxofaan added a commit that referenced this issue Oct 7, 2022
@soxofaan
fixup! fixup! Issue #114/#141 convert inline GeoJSON in aggregate_spa…
34cad31 
…tial to VectorCube
soxofaan added a commit that referenced this issue Oct 7, 2022
@soxofaan
fixup! fixup! fixup! Issue #114/#141 convert inline GeoJSON in aggreg…
a77d50a 
…ate_spatial to VectorCube
soxofaan added a commit that referenced this issue Oct 7, 2022
@soxofaan
fixup! fixup! fixup! fixup! Issue #114/#141 convert inline GeoJSON in…
f43b98b 
… aggregate_spatial to VectorCube
soxofaan added a commit that referenced this issue Oct 7, 2022
@soxofaan
fixup! fixup! fixup! fixup! fixup! Issue #114/#141 convert inline Geo…
842b3d7 
…JSON in aggregate_spatial to VectorCube
soxofaan added a commit that referenced this issue Oct 7, 2022
@soxofaan
fixup! fixup! fixup! fixup! fixup! fixup! Issue #114/#141 convert inl…
d9d9f90 
…ine GeoJSON in aggregate_spatial to VectorCube
soxofaan added a commit that referenced this issue Oct 10, 2022
@soxofaan
Issue #114/#141 convert inline GeoJSON in aggregate_spatial to Vector…
aee2c00 
…Cube

Also applied black code formatting style on changed/touched bits,
using the `darker` tool
@soxofaan
Copy link
Member

done by aee2c00

soxofaan added a commit that referenced this issue Oct 11, 2022
@soxofaan
DriverVectorCube.from_geojson: add support for Point/MultiPoint/Geome…
67e44c7 
…tryCollection

related to #71/#114/#141
soxofaan added a commit that referenced this issue Oct 12, 2022
@soxofaan
Issue #114/#141 temporarily roll back automatic conversion of inline …
2ec255e 
…Point GeoJSON to VectorCube in aggregate_spatial
soxofaan added a commit to Open-EO/openeo-geopyspark-driver that referenced this issue Oct 12, 2022
@soxofaan
Add DriverVectorCube support to batch_job.py: extract_result_metadata
8a6b3a4 
ref: Open-EO/openeo-python-driver#114, Open-EO/openeo-python-driver#141
@soxofaan
Copy link
Member

reopening to follow up failing integration tests as result of this change:

  • test_random_forest_train_and_load_from_jobid
        # Check job_metadata.json.
        with open(metadataPath, "r") as f:
            metadata = json.load(f)
>           assert metadata["geometry"].get("type", "") == "GeometryCollection"
E           AssertionError: assert 'Polygon' == 'GeometryCollection'
E             - GeometryCollection
E             + Polygon
openeo-geopyspark-integrationtests/tests/test_integration.py:601: AssertionError

  • test_integration.test_point_timeseries

    E openeo.rest.OpenEoApiError: [500] Internal: Server error: class org.locationtech.jts.geom.Point cannot be cast to class org.locationtech.jts.geom.Polygon (org.locationtech.jts.geom.Point and org.locationtech.jts.geom.Polygon are in unnamed module of loader org.apache.spark.util.MutableURLClassLoader @66629f63) (ref: r-60568a1627d94a23b7ed88fa11e07cc4)

  • test_integration.test_point_timeseries_from_batch_process

    E openeo.rest.OpenEoApiError: [500] Internal: Server error: AttributeError("'DriverVectorCube' object has no attribute 'is_empty'") (ref: r-436f0bac03f741739a56a509fea6f87e)

@soxofaan soxofaan reopened this Oct 12, 2022
soxofaan added a commit to Open-EO/openeo-geopyspark-integrationtests that referenced this issue Oct 12, 2022
@soxofaan
Update test_random_forest_train_and_load_from_jobid
9a5bbac 
ref: Open-EO/openeo-python-driver#114, Open-EO/openeo-python-driver#141
soxofaan added a commit that referenced this issue Oct 12, 2022
@soxofaan
additional bounding box methods to DriverVectorCube (#141)
8e3b58a
@soxofaan soxofaan mentioned this issue Oct 12, 2022
Closed
soxofaan added a commit to Open-EO/openeo-geopyspark-driver that referenced this issue Oct 12, 2022
@soxofaan
Improve DriverVectorCube support in batch_job.py: extract_result_meta…
aac7d4b 
…data

ref: Open-EO/openeo-python-driver#114, Open-EO/openeo-python-driver#141
@soxofaan
Copy link
Member

soxofaan commented Oct 12, 2022 •
edited
Loading

  • test_random_forest_train_and_load_from_jobid is fixed now
  • test_point_timeseries_from_batch_process passes again now
  • test_point_timeseries is still failing despite 2ec255e (it now fails in aggregate_single_point_feature, while before it was a bit earlier in aggregate_single_point)

soxofaan added a commit that referenced this issue Oct 12, 2022
@soxofaan
fixup! Issue #114/#141 temporarily roll back automatic conversion of …
4927eee 
…inline Point GeoJSON to VectorCube in aggregate_spatial
@soxofaan
Copy link
Member

Failing integration tests due to #141 changes are now fixed.
Part of it was a quick fix to roll back old behavior for point geometries (2ec255e, 4927eee).
Next up is properly handling point geometries in vector cube code paths

@soxofaan soxofaan mentioned this issue Oct 13, 2022
Closed
soxofaan added a commit that referenced this issue Oct 18, 2022
@soxofaan
Issue #114/#141/#239 re-enable automatic vector cube conversion for P…
4400565 
…oint geometries in aggregate_spatial

reverts 2ec255e and 4927eee
openeo-geopyspark-driver now properly supports point geometries
@soxofaan
Copy link
Member

problem with point geometries is addressed now as well (Open-EO/openeo-geopyspark-driver#239)
time to close this one again

@soxofaan soxofaan mentioned this issue Oct 24, 2022
Open
soxofaan added a commit that referenced this issue Oct 24, 2022
@soxofaan
Remove unused/deprecated buffer_point_approx
fea6a35 
replaced by `GeometryBufferer` helper 
related to #141, Open-EO/openeo-geopyspark-driver#239, #148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soxofaan soxofaan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@soxofaan @jdries