Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply_neighborhood : Descriptions are in conflict #385

Closed
m-mohr opened this issue Sep 23, 2022 · 1 comment · Fixed by #390
Closed

apply_neighborhood : Descriptions are in conflict #385

m-mohr opened this issue Sep 23, 2022 · 1 comment · Fixed by #390
Milestone

Comments

@m-mohr
Copy link
Member

m-mohr commented Sep 23, 2022

Process ID: apply_neighborhood

Describe the issue:
I see some contrary definitions. On the one hand, the description says:

The process must not add new dimensions, or remove entire dimensions, but the result can have different dimension labels.

On the other hand, in other places it says:

The dimension properties (name, type, labels, reference system and resolution) must remain unchanged, otherwise a DataCubePropertiesImmutable exception will be thrown.

and

A data cube with the newly computed values and the same dimensions. The dimension properties (name, type, labels, reference system and resolution) remain unchanged.

Proposed solution:

I assume the following part needs to be removed/changed:

The process must not add new dimensions, or remove entire dimensions, but the result can have different dimension labels.

Additional context:
https://discuss.eodc.eu/t/moving-average-with-low-pass-filter/428/10

@m-mohr
Copy link
Member Author

m-mohr commented Oct 5, 2022

What are your thoughts, @jdries ?

@m-mohr m-mohr added this to the 2.0.0 milestone Oct 9, 2022
@m-mohr m-mohr linked a pull request Oct 9, 2022 that will close this issue
@m-mohr m-mohr closed this as completed Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant