Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply_neighborhood: What to return when an overlap is used? #386

Closed
m-mohr opened this issue Sep 30, 2022 · 1 comment · Fixed by #390
Closed

apply_neighborhood: What to return when an overlap is used? #386

m-mohr opened this issue Sep 30, 2022 · 1 comment · Fixed by #390
Milestone

Comments

@m-mohr
Copy link
Member

m-mohr commented Sep 30, 2022

Process ID: apply_neighborhood

Describe the issue:
What I’m not clear about when working with the process is: If you specify overlap, what is expected to be returned from the callback? the data with or without overlap?

Proposed solution:
Actually, how easy is it to detect what the overlap and what the actual data is? In the end, it's probably easier to return the data with overlap, but the back-end discards any changes to the overlap and only replaces the values for the "actual data" without overlap.

Additional context:
https://discuss.eodc.eu/t/moving-average-with-low-pass-filter/428/11

@m-mohr
Copy link
Member Author

m-mohr commented Oct 5, 2022

Dev Teclo: Return with overlap, back-ends handles the rest...

@m-mohr m-mohr added this to the 2.0.0 milestone Oct 9, 2022
@m-mohr m-mohr linked a pull request Oct 9, 2022 that will close this issue
@m-mohr m-mohr closed this as completed Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant