-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implicit resampling for spatial dimensions in mask and merge_cubes + clarifications #405
Conversation
…be resampled implicitly instead of throwing an error. #402
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some quick notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From simply reading this both descriptions are clear to me/understandable (would still add the small addition from my other comment).
I understand that the reproducability issue with this change has already been discussed (and accepted) in the PSC. With that disclaimed, I still feel obligated to ask: what exactly is the principle by which it's okay for this process to violate reproducability? And is this really so difficult to fix? What would be wrong about a Btw, if folks are totally over this discussion and this is deemed not worth the effort by everyone, just ignore this comment - the content of the PR looks fine to me! |
@LukeWeidenwalker This has not been accepted by the PSC yet, we just discussed it but did not vote on it yet. I'm not 100% sure why this is hurting reproducibility? What we propose here is to just implicitly call the resample process with default parameters if required. As such this should be as reproducible as an explicit call to the resample process. |
Because without more info this doesn't specify which resampling method was used!
Ah, yes, IMHO this should be explicit. And since the default parameters can change, I'd also hard-code what this default parameter is expected to be. E.g. "The implicit resampling is performed as a |
Okay, I'll make this more explicit. I'm not sure whether It's not a good idea to also mention the default values. |
mask
andmerge_cubes
: The spatial dimensionsx
andy
can now be resampled implicitly instead of throwing an error.Also, clarify a couple of inconsistencies and conflicting descriptions. Depending on what the reader assumed as the truth, this might be breaking.
Implements #402
Fixes #379