Dock-widgets in TableView prevent TableView from closing upon application exit #736
Labels
Milestone
Comments
joernu76
added
bug
risehr
added a commit
to risehr/MSS
that referenced
this issue
Apr 5, 2021
…eView from closing upon application exit] - closing of tableview window when main MSS window is closed. Previously it used to stick around. But now it closes with MSS main window.
|
Hi @joernu76 @ReimarBauer ! I have solved this issue. Tests also passed. I have send a PR to develop. |
risehr
added a commit
to risehr/MSS
that referenced
this issue
Apr 6, 2021
risehr
added a commit
to risehr/MSS
that referenced
this issue
Apr 6, 2021
…round when main MSS window closes, now it closes perfectly fine.
ReimarBauer
pushed a commit
that referenced
this issue
Apr 7, 2021
…View from closing upon application exit (#758) * Solved issue #736. The tableview window which used to stick around when main MSS window closes, now it closes perfectly fine. * Followed PEP8 style for checking booleans as true and changed self.tv_window.tvwindow_exists() to only self.tv_window.exists()
ReimarBauer
added a commit
that referenced
this issue
Apr 9, 2021
* Add testing to stable * Added fix for #642 (#647) * Added fix for #642 * Fixed import os to fs #642 * Removed comment * Changed exists statement #642 * Fixed pylint error #642 * Editing mscolab Url must be blocked on connect #637 (#661) * mscolab disconnect #637 * Removed set editable #637 * Fix conda-forge missing in channels (#666) * added fixation for geos to <3.9.0, fixes #665 (#668) * preparation for 2.0.1 release (#675) * Use image from openmss (#677) Co-authored-by: ReimarBauer <rb.proj@gmail.com> * Install with mamba, check development.txt (#690) * fixed flake8 test, fixes #697 (#698) * Update netcdf4tools: resolves #Issue 695 (#705) Add skip_dim_check to "check each dimension has a coordinate dimension". * Fix error on empty coastsegs on land (#712) * Fix error on empty coastsegs * Add test for mapcanvas no coastlines * Fix for Issue #636 (#716) * replaced qt file picker with fs for import/export * fix for #636 * added comment * Fix sql versions (#721) created a new issue ;) #722 * Fix for issue #638 (#718) * testing fix * Fix for issue #638 * fixed qt file_filter bug * removed unused import Co-authored-by: ReimarBauer <rb.proj@gmail.com> * Readded capability to load a configuration. Updated the editor. (#732) Added capability to restart the application from within to use the changed configuration. "Save" now saves to mss configuration file. Prevent wrong JSON syntax to be saved. Properly remove reference to editor window in main window. Prevent multiple editors from being opened. Added a simple notion of a modified file to prevent unnessecary questions to user. Remaining issue: The whole editor was not created my qtcreator. Editor should IMO be a blocking dialogue because after changing the configuration a restart is necessary. Fix issue #730 * conda-forge first channel (#742) * Preparations for 2.0.2 (#744) * changes link added to about and date updated * preparation v2.0.2 * flake8 fix * Fix syntax error for sqlite sqlalchemy (#748) * (Solved issue #736 for stable)Dock-widgets in TableView prevent TableView from closing upon application exit (#758) * Solved issue #736. The tableview window which used to stick around when main MSS window closes, now it closes perfectly fine. * Followed PEP8 style for checking booleans as true and changed self.tv_window.tvwindow_exists() to only self.tv_window.exists() * fixes issue #749 (#752) * replaced absulute urls by url_for * removed links to pages * replaced redirect by render_template * url_for for menu added * overview imaage definition added * fixed scriptname for image in about * Hotfixes (#759) * Added more variants for specifying degree * Added traceback to unexpected exception handling. * Fixed some exceptions in data access class. * hybrid/level model data need no unit on the vertical axis. * In case different number of elevations are present comparison should give false, not exception. * Variables with less than three dimensions are not used anyway, so do not check them * catch more exceptions when trying to parse units attribute * Properly convert units for generic plots Co-authored-by: ReimarBauer <rb.proj@gmail.com> * prepare v2.0.3. (#763) * skipped test_home() because this needs a different setup Co-authored-by: May <baermay98@gmail.com> Co-authored-by: Aheli Ghosh <debjanihome@gmail.com> Co-authored-by: So njaGi singer <54586339+gisi90@users.noreply.github.com> Co-authored-by: Aravind Murali <aravindmurali711@gmail.com> Co-authored-by: joernu76 <j.ungermann@fz-juelich.de> Co-authored-by: Hrithik Kumar Verma <54763705+risehr@users.noreply.github.com>
ReimarBauer
added a commit
that referenced
this issue
Jun 2, 2021
… title) (#994) * ui_kmloverlay_dockwidget.ui file changed for showing color and linewidth of individual kml files * Changed the ui_kmloverlay_dockwidget.py added features of showing color and linewidth to this dockwidget (.py extension) file * Added functionality and connected slots to show the respective color and respective linewidth of individual kml files in the listwwidget( added changes to kmloverlay_dockwidget.py) * Modified 'remove_file(self)' function in kmloverlay_dockwidget.py ; added functionality for not showing color or linewidth when there are no kml files present in the listwidget * Instant changes/reflection to the color label and linewidth label when the color and linewidth is changed. And also previous code's optimization * Change color option added to main kmloverlay gui, editing of linewidth is direct in the main kmloverlay gui, display selected color of kml file right next to the file and the height of the colour block is in correspondence with the linewidth of that specific kml file * Discarded obsolete color label display and linewidth label. The icons were made to appear directly upon startup of kmloverlaywidget. On clicking kml files it shows linewidth and you can edit from there directly. * Optimized the code by setting flag to prevent the same icon being set twice because select_linewidth is called when item is clicked and also when valueChanged of spin box. Therefore, a flag is set to call select linewidth only when the value really changes. * flake8 test run successfuly without any errors * Improved functionality for setting color icons while adding files and tried the tests again * Modified test_kmloverlay_dockwidget.py test file and removed brackets from if() in kmloverlay_dockwidget.py * changes in test_wms_control/py for flake8 test to pass * Added features for hiding of linewidth & color options until a file is selected. Made linewidth editor box faster which was slowing down significantly. Made color change much faster. Modified the tests also. * Installed qt==5.9.7 and changed ui_kmloverlay_dockwidget.py and ui_kmloverlay_dockwidget.ui and removed the attribute setSteptype * Made Change Color button transparent. Added the current color of the KML file to the QColorDialog selected color. Shortened range of linewidth from 0.1 to 10 * Added .coverage to gitignore * Solved the issue #736 [Dock-widgets in TableView prevent TableView from closing upon application exit] - closing of tableview window when main MSS window is closed. Previously it used to stick around. But now it closes with MSS main window. * Made the code more understandable for solved issue #736 * Updating Merge Conflict * Synced with OpenMSS:develop * Added options in sideview to change the fontsize of x and y(both y) axes ticklabels and labels along with the plot title. * Rectified previous mistakes in gitignore file * Added fontsize configuration options for topview and added datasets for default size in MSSdefaultConfig so that user can put his default value. * Added plot options for LinearView, SideView, Topview and added default settings for users for those plot options. * Modified code to pass the tests. Co-authored-by: ReimarBauer <rb.proj@gmail.com>
Marilyth
pushed a commit
to Marilyth/MSS
that referenced
this issue
Jun 17, 2021
…and plot title) (Open-MSS#994) * ui_kmloverlay_dockwidget.ui file changed for showing color and linewidth of individual kml files * Changed the ui_kmloverlay_dockwidget.py added features of showing color and linewidth to this dockwidget (.py extension) file * Added functionality and connected slots to show the respective color and respective linewidth of individual kml files in the listwwidget( added changes to kmloverlay_dockwidget.py) * Modified 'remove_file(self)' function in kmloverlay_dockwidget.py ; added functionality for not showing color or linewidth when there are no kml files present in the listwidget * Instant changes/reflection to the color label and linewidth label when the color and linewidth is changed. And also previous code's optimization * Change color option added to main kmloverlay gui, editing of linewidth is direct in the main kmloverlay gui, display selected color of kml file right next to the file and the height of the colour block is in correspondence with the linewidth of that specific kml file * Discarded obsolete color label display and linewidth label. The icons were made to appear directly upon startup of kmloverlaywidget. On clicking kml files it shows linewidth and you can edit from there directly. * Optimized the code by setting flag to prevent the same icon being set twice because select_linewidth is called when item is clicked and also when valueChanged of spin box. Therefore, a flag is set to call select linewidth only when the value really changes. * flake8 test run successfuly without any errors * Improved functionality for setting color icons while adding files and tried the tests again * Modified test_kmloverlay_dockwidget.py test file and removed brackets from if() in kmloverlay_dockwidget.py * changes in test_wms_control/py for flake8 test to pass * Added features for hiding of linewidth & color options until a file is selected. Made linewidth editor box faster which was slowing down significantly. Made color change much faster. Modified the tests also. * Installed qt==5.9.7 and changed ui_kmloverlay_dockwidget.py and ui_kmloverlay_dockwidget.ui and removed the attribute setSteptype * Made Change Color button transparent. Added the current color of the KML file to the QColorDialog selected color. Shortened range of linewidth from 0.1 to 10 * Added .coverage to gitignore * Solved the issue Open-MSS#736 [Dock-widgets in TableView prevent TableView from closing upon application exit] - closing of tableview window when main MSS window is closed. Previously it used to stick around. But now it closes with MSS main window. * Made the code more understandable for solved issue Open-MSS#736 * Updating Merge Conflict * Synced with OpenMSS:develop * Added options in sideview to change the fontsize of x and y(both y) axes ticklabels and labels along with the plot title. * Rectified previous mistakes in gitignore file * Added fontsize configuration options for topview and added datasets for default size in MSSdefaultConfig so that user can put his default value. * Added plot options for LinearView, SideView, Topview and added default settings for users for those plot options. * Modified code to pass the tests. Co-authored-by: ReimarBauer <rb.proj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce the problem:
Expected Outcome:
Outcome;
The TopView has dockwidgets that work in this regard. One should be able to transfer the proper handling from TopView to TableView.
The text was updated successfully, but these errors were encountered: