Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfixes #759

Merged
merged 5 commits into from
Apr 7, 2021
Merged

Hotfixes #759

merged 5 commits into from
Apr 7, 2021

Conversation

joernu76
Copy link
Member

@joernu76 joernu76 commented Apr 7, 2021

No description provided.

@joernu76 joernu76 changed the base branch from develop to stable April 7, 2021 09:24
@joernu76 joernu76 requested a review from ReimarBauer April 7, 2021 09:24
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment about units please

@joernu76 joernu76 force-pushed the hotfixes branch 4 times, most recently from 44ccdda to a1a49c9 Compare April 7, 2021 10:55
@joernu76
Copy link
Member Author

joernu76 commented Apr 7, 2021

@gisi90 Some of these changes might make your life easier as well...

joernu76 added 4 commits April 7, 2021 16:35
* hybrid/level model data need no unit on the vertical axis.
* In case different number of elevations are present comparison should
  give false, not exception.
* Variables with less than three dimensions are not used anyway, so do
  not check them
* catch more exceptions when trying to parse units attribute
@ReimarBauer ReimarBauer linked an issue Apr 7, 2021 that may be closed by this pull request
@ReimarBauer ReimarBauer merged commit 04d7d75 into stable Apr 7, 2021
ReimarBauer added a commit that referenced this pull request Apr 9, 2021
* Add testing to stable

* Added fix for #642 (#647)

* Added fix for #642

* Fixed import os to fs #642

* Removed comment

* Changed exists statement #642

* Fixed pylint error #642

* Editing mscolab Url must be blocked on connect #637 (#661)

* mscolab disconnect #637

* Removed set editable #637

* Fix conda-forge missing in channels (#666)

* added fixation for geos to <3.9.0, fixes #665 (#668)

* preparation for 2.0.1 release (#675)

* Use image from openmss (#677)

Co-authored-by: ReimarBauer <rb.proj@gmail.com>

* Install with mamba, check development.txt (#690)

* fixed flake8 test, fixes #697 (#698)

* Update netcdf4tools: resolves #Issue 695 (#705)

Add skip_dim_check to "check each dimension has a coordinate dimension".

* Fix error on empty coastsegs on land (#712)

* Fix error on empty coastsegs

* Add test for mapcanvas no coastlines

* Fix for Issue #636 (#716)

* replaced qt file picker with fs for import/export

* fix for #636

* added comment

* Fix sql versions (#721)

created a new issue ;)
#722

* Fix for issue #638 (#718)

* testing fix

* Fix for issue #638

* fixed qt file_filter bug

* removed unused import

Co-authored-by: ReimarBauer <rb.proj@gmail.com>

* Readded capability to load a configuration. Updated the editor. (#732)

Added capability to restart the application from within to use the
changed configuration. "Save" now saves to mss configuration file.
Prevent wrong JSON syntax to be saved. Properly remove reference to
editor window in main window. Prevent multiple editors from being
opened. Added a simple notion of a modified file to prevent unnessecary
questions to user.

Remaining issue: The whole editor was not created my qtcreator. Editor
should IMO be a blocking dialogue because after changing the
configuration a restart is necessary.

Fix issue #730

* conda-forge first channel (#742)

* Preparations for 2.0.2 (#744)

* changes link added to about and date updated

* preparation v2.0.2

* flake8 fix

* Fix syntax error for sqlite sqlalchemy (#748)

* (Solved issue #736 for stable)Dock-widgets in TableView prevent TableView from closing upon application exit (#758)

* Solved issue #736. The tableview window which used to stick around when main MSS window closes, now it closes perfectly fine.

* Followed PEP8 style for checking booleans as true and changed self.tv_window.tvwindow_exists() to only self.tv_window.exists()

* fixes issue #749  (#752)

* replaced absulute urls by url_for

* removed links to pages

* replaced redirect by render_template

* url_for for menu added

* overview imaage definition added

* fixed scriptname for image in about

* Hotfixes (#759)

* Added more variants for specifying degree

* Added traceback to unexpected exception handling.

* Fixed some exceptions in data access class.

* hybrid/level model data need no unit on the vertical axis.
* In case different number of elevations are present comparison should
  give false, not exception.
* Variables with less than three dimensions are not used anyway, so do
  not check them
* catch more exceptions when trying to parse units attribute

* Properly convert units for generic plots

Co-authored-by: ReimarBauer <rb.proj@gmail.com>

* prepare v2.0.3. (#763)

* skipped test_home() because this needs a different setup

Co-authored-by: May <baermay98@gmail.com>
Co-authored-by: Aheli Ghosh <debjanihome@gmail.com>
Co-authored-by: So njaGi singer <54586339+gisi90@users.noreply.github.com>
Co-authored-by: Aravind Murali <aravindmurali711@gmail.com>
Co-authored-by: joernu76 <j.ungermann@fz-juelich.de>
Co-authored-by: Hrithik Kumar Verma <54763705+risehr@users.noreply.github.com>
@joernu76 joernu76 deleted the hotfixes branch April 9, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dataaccess units problems
2 participants