Fixes #769 parameter should be global for interaction container #770
Conversation
| { | ||
| var node = new MoleculeTreeNode(input) {Text = input.Name, Icon = ApplicationIcons.IconByName(input.Icon)}; |
There was a problem hiding this comment.
All the changes here are just a million typos in the file. Not related to actual change
|
|
||
| protected override ParameterBuildMode GetBuildModeType() | ||
| { | ||
| return ParameterBuildMode.Global; |
There was a problem hiding this comment.
Observations from the base test class are automatically executed when running the tests in the derived class?
I did not know it
There was a problem hiding this comment.
yeah it's because it's derived and we try to find an Obervation in each class. Pretty neat (but potentially way over engineered in this case)
There was a problem hiding this comment.
I think it's pretty usefull.
In the case like this I have always defined a function testXY() in the base class and the observation in each derived class which just called testXY() - which could be avoided with this feature :)
| @@ -27,7 +27,8 @@ public static IEnumerable<ParameterBuildMode> AvailableBuildModeForParameters(th | |||
| public static ParameterBuildMode DefaultParameterBuildMode(this IContainer container) | |||
| { | |||
| var needsGlobalParameter = container.IsAnImplementationOf<TransporterMoleculeContainer>() || | |||
| container.IsAnImplementationOf<IReactionBuilder>(); | |||
| container.IsAnImplementationOf<IReactionBuilder>() || | |||
| container.IsAnImplementationOf<InteractionContainer>(); | |||
|
Nice! Thanks for the quick fix! |
No description provided.