FreeRTOS Avoid mem mapping in MPU for region mapped #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmooring
requested changes
Feb 10, 2024
lib/system/freertos/xlnx/sys.c
Outdated
| Xil_GetMPUConfig(mpu_config); | ||
|
|
||
| for (cnt = 0; (cnt < MAX_POSSIBLE_MPU_REGS) && | ||
| (mpu_config[cnt].flags & XMPU_VALID_REGION); cnt++){ |
There was a problem hiding this comment.
This loop will terminate early if the MPU register mappings are sparse. If registers 0, 1, and 3 have valid regions, but 2 does not, 3 will be skipped.
I think this part of the test should be moved into the loop as an if() continue statement.
rajimoha
force-pushed
the
freeRTOSsyschanges
branch
from
18f7d5b to
d5c2c33
Compare
|
@edmooring changes done.. ping for review |
arnopo
requested changes
Feb 19, 2024
rajimoha
force-pushed
the
freeRTOSsyschanges
branch
from
d5c2c33 to
0c64c14
Compare
FreeRTOS patch for Avoiding memory mapping in MPU config table for region that are already mapped by bsp and no change in attribute property Signed-off-by: Rajiv Mohan <rajiv.mohan@amd.com>
rajimoha
force-pushed
the
freeRTOSsyschanges
branch
from
0c64c14 to
228aa5f
Compare
|
@arnopo fixed the commit msg format issue. |
arnopo
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeRTOS patch for Avoiding memory mapping in MPU config table for region that are already mapped by bsp and no change in attribute property