-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Do Zephyr build tests on known good and latest versions #307
Conversation
@arnopo |
ac346a3
to
23d19af
Compare
23d19af
to
538a9de
Compare
@arnopo @tnmysh @edmooring |
# Break the zephyr builds into their own job as the common runner was | ||
# running out of space when runs were together | ||
# Also, as the longest running jobs, this allows them to run in || | ||
zephyr_build_known_good: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about stable instead of "good" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't like stable. The know good version does not need to be a release, just a recent point that is know to work. If it is a release, it does not need to be the most recent stable release.
However "know good version" is a term I have used for decades and I am not the only one:
https://github.com/GoogleChromeLabs/chrome-for-testing?tab=readme-ov-file#json-api-endpoints
I can add _version. That makes it easier to understand.
|
||
# run weekly on Sunday at 5:10 AM UTC (9:10 PM US western) | ||
schedule: | ||
- cron: '10 5 * * 0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: what happen if it fails. A message is sent on the mailing list, or do we have to check action result each week?
Allow Zephyr testing to either use locked known good values or the very latest versions. The known good versions are best for PR checking as if the build fails it is almost always the PR itself that broke it. The latest version is good for periodically checking compatibility with the very latest Zephyr changes. For now we run both on pushes and PRs. We also run main against the latest zephyr check weekly as a look ahead. Signed-off-by: Bill Mills <bill.mills@linaro.org>
538a9de
to
917593b
Compare
Pushed with some language updates as describe above. |
@arnopo why do we ignore changes to cmake/* and scripts/*?? Changes there are the most likely to cause problems for the builds. Are you OK if I start another PR to remove those ignore paths? |
The answer seem to be here: I don't see anyway to send that to an email list. We can change who it goes to by disable and then enable. The last enable is the winner. We could also add a badge on the readme. |
Mainly to avoid issue with checkpatch and to avoid running build on non-library code (no true for cmake)
yes sure! |
Regarding the article you pointed out and this article: https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28, In such case we could run it for each PR but returning something else than |
Allow Zephyr testing to either use locked known good values or the very latest versions.
The known good versions are best for PR checking as if the build fails it is almost always the PR itself that broke it.
The latest version is good for periodically checking compatibility with the very latest Zephyr changes.
For now we run both on pushes and PRs.
We also run main against the latest zephyr check weekly as a look ahead.
Fixes: #295