Idiomatic Rust returns for Error conversions #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll rebase and run trough the process. |
bjgill
force-pushed
the
patch-1
branch
2 times, most recently
from
7cec0d1
to
a799a6b
Compare
|
OK - after a few false starts, I've now got it rebased against master, with the samples regenerated. It looks as if the samples haven't been updated in a while, so some extraneous changes have got pulled in. This is therefore ready for review. Thanks for the contribution! |
|
@frol @farcaller - this (small) PR is ready for review. Otherwise, I'll merge this on Wednesday |
fantavlik
added a commit
to fantavlik/openapi-generator
that referenced
this pull request
Jun 17, 2019
…to inline-resolver * 'master' of github.com:OpenAPITools/openapi-generator: (213 commits) Idiomatic Rust returns for Error conversions (OpenAPITools#2812) Add API timeout handling (OpenAPITools#3078) Import inner items for map (OpenAPITools#3123) update core team in pom.xml (OpenAPITools#3126) [gradle] Document consuming via gradle plugin portal (OpenAPITools#3125) Bump up babel-cli version to fix security alert (OpenAPITools#3121) [C++] [cpprestsdk] Add examples and test for cpprestsdk (OpenAPITools#3109) Add enum support to `rust` and skip none option serialization in clients (OpenAPITools#2244) Add/update new core team member: etherealjoy (OpenAPITools#3116) Gradle sample on travis (OpenAPITools#3114) [typescript-fetch] add bearer token support (OpenAPITools#3097) Add Q_DECLARE_METATYPE to the generated models and remove ref in signals (OpenAPITools#3091) [Java][okhttp-gson] Update dependencies (OpenAPITools#3103) Link query parameter to model object (OpenAPITools#2710) scala-play-server: fix enum names for reserved words (OpenAPITools#3080) Add @Sunn to openapi generator core team (OpenAPITools#3105) fix NPE in go generator (OpenAPITools#3104) scala-play-server: fix API doc url (OpenAPITools#3096) [maven-plugin] fix strictSpec parameter without alias (OpenAPITools#3095) Ruby: Avoid double escaping path items (OpenAPITools#3093) ... # Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelResolver.java # modules/openapi-generator/src/test/java/org/openapitools/codegen/InlineModelResolverTest.java
|
Thanks again for the PR, which has been included in the v4.0.2 release: https://twitter.com/oas_generator/status/1141610197766426626 |
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Jun 24, 2019
* master: (25 commits) Add #send to ruby reserved word list (OpenAPITools#3146) Merge java8 doc for spring (OpenAPITools#3122) added api key authentication to aspnetcore 2.1 (OpenAPITools#3089) Add "yue9944882" to Perl technical committee (OpenAPITools#3194) [csharp-netcore]: Adding http response details in api_docs and making example snippet compilable (OpenAPITools#3128) generate travis configuration (OpenAPITools#3193) Perl: Basic bearer auth support (OpenAPITools#3192) [R] feat(r) : Alternate PR for serialization fixes along with WithHttpInfo method enhancement (OpenAPITools#3099) improve release checkout script (OpenAPITools#3184) Prepare 4.0.3-SNAPSHOT (OpenAPITools#3185) 4.0.2 release (OpenAPITools#3181) Fix rubocop obsolescence (OpenAPITools#3175) Add Fuse to the company list (OpenAPITools#3164) Idiomatic Rust returns for Error conversions (OpenAPITools#2812) Add API timeout handling (OpenAPITools#3078) Import inner items for map (OpenAPITools#3123) update core team in pom.xml (OpenAPITools#3126) [gradle] Document consuming via gradle plugin portal (OpenAPITools#3125) Bump up babel-cli version to fix security alert (OpenAPITools#3121) [C++] [cpprestsdk] Add examples and test for cpprestsdk (OpenAPITools#3109) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Will fill out the PR Checklist later. Feel free to copy/pasta if you're ready to go through the process (I was looking to just make a quick contribution and will have to come back to this when I have time)